bound extensionName compare to VK_MAX_EXTENSION_NAME_SIZE - #2042
Merged
charles-lunarg merged 1 commit intoSep 30, 2026
Merged
Conversation
|
Author aizu-m not on autobuild list. Waiting for curator authorization before starting CI build. |
1 similar comment
|
Author aizu-m not on autobuild list. Waiting for curator authorization before starting CI build. |
charles-lunarg
approved these changes
Sep 29, 2026
|
CI Vulkan-Loader build queued with queue ID 136521. |
|
CI Vulkan-Loader build # 3785 running. |
|
CI Vulkan-Loader build # 3785 passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the extension de-duplication path compares two VkExtensionProperties::extensionName values with an unbounded strcmp, so a driver that returns a name filling all VK_MAX_EXTENSION_NAME_SIZE bytes with no terminator makes the compare read past the field and off the end of the list allocation; strncmp bounds it to the array, matching the check already used for driver extension names in extension_manual.c.