Repository navigation
Android.mk: guard with NDK_ROOT - #6925
Merged
Merged
Conversation
Wrap the contents of Android.mk in `ifdef NDK_ROOT ... endif`. Android.mk in this repository is intended solely for standalone Android NDK builds (`ndk-build`). When the repository is vendored or imported into an Android platform tree (AOSP / Soong), the platform build system (Kati) discovers and evaluates this file. This can cause build failures, such as module name collisions with Soong's Android.bp (e.g. duplicate definitions for `SPIRV-Tools`) and missing NDK-specific variables. Because `NDK_ROOT` is set by the NDK's core build scripts during `ndk-build` but is unset during Android platform builds, this guard ensures the file is treated as a no-op during platform builds while keeping `ndk-build` functional.
Contributor
Author
|
@s-perron could you please take a look? |
|
|
s-perron
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrap the contents of Android.mk in
ifdef NDK_ROOT ... endif.Android.mk in this repository is intended solely for standalone Android NDK builds (
ndk-build). When the repository is vendored or imported into an Android platform tree (AOSP / Soong), the platform build system (Kati) discovers and evaluates this file. This can cause build failures, such as module name collisions with Soong's Android.bp (e.g. duplicate definitions forSPIRV-Tools) and missing NDK-specific variables.Because
NDK_ROOTis set by the NDK's core build scripts duringndk-buildbut is unset during Android platform builds, this guard ensures the file is treated as a no-op during platform builds while keepingndk-buildfunctional.