Fix incorrect padding of accumulated data size rather than current level's size - #1242
Merged
Conversation
Set writeOffset from prototype level index. Remove unnecessary setting of prototype level index values after transcoding an image. They were already set when the prototype was created.
MarkCallow
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The transcode functions were padding the accumulated level sizes. They should have been padding the current level's size before adding it to the accumulated size. This led to a check for an output buffer of sufficient size to fail in the underlying Basis transcoders.
While investigating I observed that the transcode functions were unnecessarily keeping track of level sizes and writing the level index fields of the prototype transcoded texture based on this tracking. The level index is correctly set when the prototype is created. Now it is used to pass write offsets to the underlying Basis transcoders and this PR deletes the unnecessary tracking and level-index writes. A nice simplification.
Fixes #1241.