Fix remaining cpplint issues: C-style casts and missing includes by hendrikmuhs · Pull Request #475 · KeyviDev/keyvi

hendrikmuhs · 2026-10-20T19:15:44Z

final pre-commit fixes for pre-commit -a

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 10 out of 24. Check the log or trigger a new build to see more.

github-actions · 2026-10-20T19:26:55Z

      return "";
    } else {
-      return predictor_table_[(uint16_t(bigram[0]) << 8) + bigram[1]];
+      return predictor_table_[(static_cast<uint16_t>(bigram[0]) << 8) + bigram[1]];


warning: do not use array subscript when the index is not an integer constant expression [cppcoreguidelines-pro-bounds-constant-array-index]

return predictor_table_[(static_cast<uint16_t>(bigram[0]) << 8) + bigram[1]]; ^

github-actions · 2026-10-20T19:26:56Z

      return "";
    } else {
-      return predictor_table_[(uint16_t(bigram[0]) << 8) + bigram[1]];
+      return predictor_table_[(static_cast<uint16_t>(bigram[0]) << 8) + bigram[1]];


warning: do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic]

return predictor_table_[(static_cast<uint16_t>(bigram[0]) << 8) + bigram[1]]; ^

github-actions · 2026-10-20T19:26:56Z

      return "";
    } else {
-      return predictor_table_[(uint16_t(bigram[0]) << 8) + bigram[1]];
+      return predictor_table_[(static_cast<uint16_t>(bigram[0]) << 8) + bigram[1]];


warning: do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic]

return predictor_table_[(static_cast<uint16_t>(bigram[0]) << 8) + bigram[1]]; ^

github-actions · 2026-10-20T19:26:56Z

      return "";
    } else {
-      return predictor_table_[(uint16_t(bigram[0]) << 8) + bigram[1]];
+      return predictor_table_[(static_cast<uint16_t>(bigram[0]) << 8) + bigram[1]];


warning: no header providing "uint16_t" is directly included [misc-include-cleaner]

keyvi/include/keyvi/compression/predictive_compression.h:29:

- #include <cstdio> + #include <cstdint> + #include <cstdio>

github-actions · 2026-10-20T19:26:56Z

      return "";
    } else {
-      return predictor_table_[(uint16_t(bigram[0]) << 8) + bigram[1]];
+      return predictor_table_[(static_cast<uint16_t>(bigram[0]) << 8) + bigram[1]];


warning: use of a signed integer operand with a binary bitwise operator [hicpp-signed-bitwise]

return predictor_table_[(static_cast<uint16_t>(bigram[0]) << 8) + bigram[1]]; ^

github-actions · 2026-10-20T19:26:56Z

      instream.get(c);
      if (instream.eof()) break;
-      uint16_t index = (uint16_t(c) << 8) + (uint16_t)instream.get();
+      uint16_t index = (static_cast<uint16_t>(c) << 8) + static_cast<uint16_t>(instream.get());


warning: use of a signed integer operand with a binary bitwise operator [hicpp-signed-bitwise]

uint16_t index = (static_cast<uint16_t>(c) << 8) + static_cast<uint16_t>(instream.get()); ^

github-actions · 2026-10-20T19:26:56Z

      instream.get(c);
      if (instream.eof()) break;
-      uint16_t index = (uint16_t(c) << 8) + (uint16_t)instream.get();
+      uint16_t index = (static_cast<uint16_t>(c) << 8) + static_cast<uint16_t>(instream.get());


warning: variable 'index' of type 'uint16_t' (aka 'unsigned short') can be declared 'const' [misc-const-correctness]

Suggested change

uint16_t index = (static_cast<uint16_t>(c) << 8) + static_cast<uint16_t>(instream.get());

uint16_t const index = (static_cast<uint16_t>(c) << 8) + static_cast<uint16_t>(instream.get());

github-actions · 2026-10-20T19:26:56Z

 #include <array>
 #include <limits>
+#include <utility>



warning: included header utility is not used directly [misc-include-cleaner]

Suggested change

github-actions · 2026-10-20T19:26:56Z

   * @param bit the bit to set.
   */
-  inline void Set(const size_t bit) { bits_[bit >> 6] |= (uint64_t)1 << (bit & 63); }
+  inline void Set(const size_t bit) { bits_[bit >> 6] |= static_cast<uint64_t>(1) << (bit & 63); }


warning: function 'Set' has inline specifier but is implicitly inlined [readability-redundant-inline-specifier]

Suggested change

inline void Set(const size_t bit) { bits_[bit >> 6] |= static_cast<uint64_t>(1) << (bit & 63); }

void Set(const size_t bit) { bits_[bit >> 6] |= static_cast<uint64_t>(1) << (bit & 63); }

github-actions · 2026-10-20T19:26:56Z

   * @param bit the bit to set.
   */
-  inline void Set(const size_t bit) { bits_[bit >> 6] |= (uint64_t)1 << (bit & 63); }
+  inline void Set(const size_t bit) { bits_[bit >> 6] |= static_cast<uint64_t>(1) << (bit & 63); }


warning: no header providing "size_t" is directly included [misc-include-cleaner]

inline void Set(const size_t bit) { bits_[bit >> 6] |= static_cast<uint64_t>(1) << (bit & 63); } ^

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 10 out of 16. Check the log or trigger a new build to see more.

github-actions · 2026-10-20T20:14:16Z

      return "";
    } else {
-      return predictor_table_[(uint16_t(bigram[0]) << 8) + bigram[1]];
+      return predictor_table_[(static_cast<unsigned>(bigram[0]) << 8) + bigram[1]];


warning: do not use array subscript when the index is not an integer constant expression [cppcoreguidelines-pro-bounds-constant-array-index]

return predictor_table_[(static_cast<unsigned>(bigram[0]) << 8) + bigram[1]]; ^

github-actions · 2026-10-20T20:14:16Z

      return "";
    } else {
-      return predictor_table_[(uint16_t(bigram[0]) << 8) + bigram[1]];
+      return predictor_table_[(static_cast<unsigned>(bigram[0]) << 8) + bigram[1]];


warning: do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic]

return predictor_table_[(static_cast<unsigned>(bigram[0]) << 8) + bigram[1]]; ^

github-actions · 2026-10-20T20:14:17Z

      return "";
    } else {
-      return predictor_table_[(uint16_t(bigram[0]) << 8) + bigram[1]];
+      return predictor_table_[(static_cast<unsigned>(bigram[0]) << 8) + bigram[1]];


warning: do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic]

return predictor_table_[(static_cast<unsigned>(bigram[0]) << 8) + bigram[1]]; ^

github-actions · 2026-10-20T20:14:17Z

      return "";
    } else {
-      return predictor_table_[(uint16_t(bigram[0]) << 8) + bigram[1]];
+      return predictor_table_[(static_cast<unsigned>(bigram[0]) << 8) + bigram[1]];


warning: use of a signed integer operand with a binary bitwise operator [hicpp-signed-bitwise]

return predictor_table_[(static_cast<unsigned>(bigram[0]) << 8) + bigram[1]]; ^

github-actions · 2026-10-20T20:14:17Z

      instream.get(c);
      if (instream.eof()) break;
-      uint16_t index = (uint16_t(c) << 8) + (uint16_t)instream.get();
+      const uint16_t index = ((static_cast<unsigned>(c) & 0xFFu) << 8) + instream.get();


warning: integer literal has suffix 'u', which is not uppercase [hicpp-uppercase-literal-suffix]

Suggested change

const uint16_t index = ((static_cast<unsigned>(c) & 0xFFu) << 8) + instream.get();

const uint16_t index = ((static_cast<unsigned>(c) & 0xFFU) << 8) + instream.get();

github-actions · 2026-10-20T20:14:17Z

      instream.get(c);
      if (instream.eof()) break;
-      uint16_t index = (uint16_t(c) << 8) + (uint16_t)instream.get();
+      const uint16_t index = ((static_cast<unsigned>(c) & 0xFFu) << 8) + instream.get();


warning: use of a signed integer operand with a binary bitwise operator [hicpp-signed-bitwise]

const uint16_t index = ((static_cast<unsigned>(c) & 0xFFu) << 8) + instream.get(); ^

github-actions · 2026-10-20T20:14:17Z

   * @param bit the bit to set.
   */
-  inline void Set(const size_t bit) { bits_[bit >> 6] |= (uint64_t)1 << (bit & 63); }
+  void Set(const size_t bit) { bits_[bit >> 6] |= static_cast<uint64_t>(1) << (bit & 63); }


warning: use of a signed integer operand with a binary bitwise operator [hicpp-signed-bitwise]

void Set(const size_t bit) { bits_[bit >> 6] |= static_cast<uint64_t>(1) << (bit & 63); } ^

github-actions · 2026-10-20T20:14:17Z

   * @param bit the bit to set.
   */
-  inline void Set(const size_t bit) { bits_[bit >> 6] |= (uint64_t)1 << (bit & 63); }
+  void Set(const size_t bit) { bits_[bit >> 6] |= static_cast<uint64_t>(1) << (bit & 63); }


warning: use of a signed integer operand with a binary bitwise operator [hicpp-signed-bitwise]

void Set(const size_t bit) { bits_[bit >> 6] |= static_cast<uint64_t>(1) << (bit & 63); } ^

github-actions · 2026-10-20T20:14:17Z

   * @param bit the bit to erase.
   */
-  inline void Erase(const size_t bit) { bits_[bit >> 6] &= (uint64_t)(~(1 << (bit & 63))); }
+  void Erase(const size_t bit) { bits_[bit >> 6] &= static_cast<uint64_t>(~(1ULL << (bit & 63))); }


warning: use of a signed integer operand with a binary bitwise operator [hicpp-signed-bitwise]

void Erase(const size_t bit) { bits_[bit >> 6] &= static_cast<uint64_t>(~(1ULL << (bit & 63))); } ^

github-actions · 2026-10-20T20:14:17Z

   * @param bit the bit to erase.
   */
-  inline void Erase(const size_t bit) { bits_[bit >> 6] &= (uint64_t)(~(1 << (bit & 63))); }
+  void Erase(const size_t bit) { bits_[bit >> 6] &= static_cast<uint64_t>(~(1ULL << (bit & 63))); }


warning: use of a signed integer operand with a binary bitwise operator [hicpp-signed-bitwise]

void Erase(const size_t bit) { bits_[bit >> 6] &= static_cast<uint64_t>(~(1ULL << (bit & 63))); } ^

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 10 out of 19. Check the log or trigger a new build to see more.

github-actions · 2026-10-20T20:45:14Z

      return "";
    } else {
-      return predictor_table_[(uint16_t(bigram[0]) << 8) + bigram[1]];
+      return predictor_table_[(static_cast<unsigned>(bigram[0]) << 8u) + bigram[1]];


warning: do not use array subscript when the index is not an integer constant expression [cppcoreguidelines-pro-bounds-constant-array-index]

return predictor_table_[(static_cast<unsigned>(bigram[0]) << 8u) + bigram[1]]; ^

github-actions · 2026-10-20T20:45:14Z

      return "";
    } else {
-      return predictor_table_[(uint16_t(bigram[0]) << 8) + bigram[1]];
+      return predictor_table_[(static_cast<unsigned>(bigram[0]) << 8u) + bigram[1]];


warning: do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic]

return predictor_table_[(static_cast<unsigned>(bigram[0]) << 8u) + bigram[1]]; ^

github-actions · 2026-10-20T20:45:14Z

      return "";
    } else {
-      return predictor_table_[(uint16_t(bigram[0]) << 8) + bigram[1]];
+      return predictor_table_[(static_cast<unsigned>(bigram[0]) << 8u) + bigram[1]];


warning: do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic]

return predictor_table_[(static_cast<unsigned>(bigram[0]) << 8u) + bigram[1]]; ^

github-actions · 2026-10-20T20:45:14Z

      return "";
    } else {
-      return predictor_table_[(uint16_t(bigram[0]) << 8) + bigram[1]];
+      return predictor_table_[(static_cast<unsigned>(bigram[0]) << 8u) + bigram[1]];


warning: integer literal has suffix 'u', which is not uppercase [hicpp-uppercase-literal-suffix]

Suggested change

return predictor_table_[(static_cast<unsigned>(bigram[0]) << 8u) + bigram[1]];

return predictor_table_[(static_cast<unsigned>(bigram[0]) << 8U) + bigram[1]];

github-actions · 2026-10-20T20:45:14Z

      instream.get(c);
      if (instream.eof()) break;
-      uint16_t index = (uint16_t(c) << 8) + (uint16_t)instream.get();
+      const uint16_t index = ((static_cast<unsigned>(c) & 0xFFU) << 8u) + instream.get();


warning: integer literal has suffix 'u', which is not uppercase [hicpp-uppercase-literal-suffix]

Suggested change

const uint16_t index = ((static_cast<unsigned>(c) & 0xFFU) << 8u) + instream.get();

const uint16_t index = ((static_cast<unsigned>(c) & 0xFFU) << 8U) + instream.get();

github-actions · 2026-10-20T20:45:14Z

   * @param bit the bit to set.
   */
-  inline void Set(const size_t bit) { bits_[bit >> 6] |= (uint64_t)1 << (bit & 63); }
+  void Set(const size_t bit) { bits_[bit >> 6u] |= static_cast<uint64_t>(1) << (bit & 63u); }


warning: integer literal has suffix 'u', which is not uppercase [hicpp-uppercase-literal-suffix]

Suggested change

void Set(const size_t bit) { bits_[bit >> 6u] |= static_cast<uint64_t>(1) << (bit & 63u); }

void Set(const size_t bit) { bits_[bit >> 6U] |= static_cast<uint64_t>(1) << (bit & 63u); }

github-actions · 2026-10-20T20:45:14Z

   * @param bit the bit to set.
   */
-  inline void Set(const size_t bit) { bits_[bit >> 6] |= (uint64_t)1 << (bit & 63); }
+  void Set(const size_t bit) { bits_[bit >> 6u] |= static_cast<uint64_t>(1) << (bit & 63u); }


warning: integer literal has suffix 'u', which is not uppercase [hicpp-uppercase-literal-suffix]

Suggested change

void Set(const size_t bit) { bits_[bit >> 6u] |= static_cast<uint64_t>(1) << (bit & 63u); }

void Set(const size_t bit) { bits_[bit >> 6u] |= static_cast<uint64_t>(1) << (bit & 63U); }

github-actions · 2026-10-20T20:45:14Z

   * @param bit the bit to erase.
   */
-  inline void Erase(const size_t bit) { bits_[bit >> 6] &= (uint64_t)(~(1 << (bit & 63))); }
+  void Erase(const size_t bit) { bits_[bit >> 6u] &= static_cast<uint64_t>(~(1ULL << (bit & 63u))); }


warning: integer literal has suffix 'u', which is not uppercase [hicpp-uppercase-literal-suffix]

Suggested change

void Erase(const size_t bit) { bits_[bit >> 6u] &= static_cast<uint64_t>(~(1ULL << (bit & 63u))); }

void Erase(const size_t bit) { bits_[bit >> 6U] &= static_cast<uint64_t>(~(1ULL << (bit & 63u))); }

github-actions · 2026-10-20T20:45:14Z

   * @param bit the bit to erase.
   */
-  inline void Erase(const size_t bit) { bits_[bit >> 6] &= (uint64_t)(~(1 << (bit & 63))); }
+  void Erase(const size_t bit) { bits_[bit >> 6u] &= static_cast<uint64_t>(~(1ULL << (bit & 63u))); }


warning: integer literal has suffix 'u', which is not uppercase [hicpp-uppercase-literal-suffix]

Suggested change

void Erase(const size_t bit) { bits_[bit >> 6u] &= static_cast<uint64_t>(~(1ULL << (bit & 63u))); }

void Erase(const size_t bit) { bits_[bit >> 6u] &= static_cast<uint64_t>(~(1ULL << (bit & 63U))); }

github-actions · 2026-10-20T20:45:14Z

   */
-  inline bool Get(const size_t bit) const { return (bits_[bit >> 6] & ((uint64_t)1 << (bit & 63))) != 0; }
+  [[nodiscard]] bool Get(const size_t bit) const {
+    return (bits_[bit >> 6u] & (static_cast<uint64_t>(1) << (bit & 63u))) != 0;


warning: integer literal has suffix 'u', which is not uppercase [hicpp-uppercase-literal-suffix]

Suggested change

return (bits_[bit >> 6u] & (static_cast<uint64_t>(1) << (bit & 63u))) != 0;

return (bits_[bit >> 6U] & (static_cast<uint64_t>(1) << (bit & 63u))) != 0;

github-actions

clang-tidy made some suggestions

github-actions · 2026-10-20T20:49:20Z

   */
-  inline bool Get(const size_t bit) const { return (bits_[bit >> 6] & ((uint64_t)1 << (bit & 63))) != 0; }
+  [[nodiscard]] bool Get(const size_t bit) const {
+    return (bits_[bit >> 6u] & (static_cast<uint64_t>(1) << (bit & 63u))) != 0;


warning: integer literal has suffix 'u', which is not uppercase [hicpp-uppercase-literal-suffix]

Suggested change

return (bits_[bit >> 6u] & (static_cast<uint64_t>(1) << (bit & 63u))) != 0;

return (bits_[bit >> 6u] & (static_cast<uint64_t>(1) << (bit & 63U))) != 0;

github-actions · 2026-10-20T20:49:20Z

  PackedState() : PackedState(0, 0, 0) {}
  PackedState(OffsetTypeT offset, HashCodeTypeT hashcode, int num_outgoing)
-      : offset_(offset), hashcode_(hashcode), num_outgoing_and_cookie_((uint32_t)(num_outgoing & 0x1FF)) {}
+      : offset_(offset), hashcode_(hashcode), num_outgoing_and_cookie_(static_cast<uint32_t>(num_outgoing) & 0x1FFu) {}


warning: integer literal has suffix 'u', which is not uppercase [hicpp-uppercase-literal-suffix]

Suggested change

: offset_(offset), hashcode_(hashcode), num_outgoing_and_cookie_(static_cast<uint32_t>(num_outgoing) & 0x1FFu) {}

: offset_(offset), hashcode_(hashcode), num_outgoing_and_cookie_(static_cast<uint32_t>(num_outgoing) & 0x1FFU) {}

github-actions · 2026-10-20T20:49:20Z

  HashCodeTypeT GetHashcode() const { return hashcode_; }

-  int GetNumberOfOutgoingTransitions() const { return static_cast<int>(this->num_outgoing_and_cookie_ & 0x1FF); }
+  int GetNumberOfOutgoingTransitions() const { return static_cast<int>(this->num_outgoing_and_cookie_ & 0x1FFu); }


warning: function 'GetNumberOfOutgoingTransitions' should be marked [[nodiscard]] [modernize-use-nodiscard]

Suggested change

int GetNumberOfOutgoingTransitions() const { return static_cast<int>(this->num_outgoing_and_cookie_ & 0x1FFu); }

[[nodiscard]] int GetNumberOfOutgoingTransitions() const { return static_cast<int>(this->num_outgoing_and_cookie_ & 0x1FFu); }

github-actions · 2026-10-20T20:49:20Z

  HashCodeTypeT GetHashcode() const { return hashcode_; }

-  int GetNumberOfOutgoingTransitions() const { return static_cast<int>(this->num_outgoing_and_cookie_ & 0x1FF); }
+  int GetNumberOfOutgoingTransitions() const { return static_cast<int>(this->num_outgoing_and_cookie_ & 0x1FFu); }


warning: integer literal has suffix 'u', which is not uppercase [hicpp-uppercase-literal-suffix]

Suggested change

int GetNumberOfOutgoingTransitions() const { return static_cast<int>(this->num_outgoing_and_cookie_ & 0x1FFu); }

int GetNumberOfOutgoingTransitions() const { return static_cast<int>(this->num_outgoing_and_cookie_ & 0x1FFU); }

github-actions · 2026-10-20T20:49:20Z

+  int GetNumberOfOutgoingTransitions() const { return static_cast<int>(this->num_outgoing_and_cookie_ & 0x1FFu); }

-  int GetCookie() const { return static_cast<int>((this->num_outgoing_and_cookie_ & 0xFFFFFE00) >> 9); }
+  int GetCookie() const { return static_cast<int>((this->num_outgoing_and_cookie_ & 0xFFFFFE00u) >> 9u); }


warning: function 'GetCookie' should be marked [[nodiscard]] [modernize-use-nodiscard]

Suggested change

int GetCookie() const { return static_cast<int>((this->num_outgoing_and_cookie_ & 0xFFFFFE00u) >> 9u); }

[[nodiscard]] int GetCookie() const { return static_cast<int>((this->num_outgoing_and_cookie_ & 0xFFFFFE00u) >> 9u); }

github-actions · 2026-10-20T20:49:20Z

+  int GetNumberOfOutgoingTransitions() const { return static_cast<int>(this->num_outgoing_and_cookie_ & 0x1FFu); }

-  int GetCookie() const { return static_cast<int>((this->num_outgoing_and_cookie_ & 0xFFFFFE00) >> 9); }
+  int GetCookie() const { return static_cast<int>((this->num_outgoing_and_cookie_ & 0xFFFFFE00u) >> 9u); }


warning: integer literal has suffix 'u', which is not uppercase [hicpp-uppercase-literal-suffix]

Suggested change

int GetCookie() const { return static_cast<int>((this->num_outgoing_and_cookie_ & 0xFFFFFE00u) >> 9u); }

int GetCookie() const { return static_cast<int>((this->num_outgoing_and_cookie_ & 0xFFFFFE00U) >> 9u); }

github-actions · 2026-10-20T20:49:20Z

+  int GetNumberOfOutgoingTransitions() const { return static_cast<int>(this->num_outgoing_and_cookie_ & 0x1FFu); }

-  int GetCookie() const { return static_cast<int>((this->num_outgoing_and_cookie_ & 0xFFFFFE00) >> 9); }
+  int GetCookie() const { return static_cast<int>((this->num_outgoing_and_cookie_ & 0xFFFFFE00u) >> 9u); }


warning: integer literal has suffix 'u', which is not uppercase [hicpp-uppercase-literal-suffix]

Suggested change

int GetCookie() const { return static_cast<int>((this->num_outgoing_and_cookie_ & 0xFFFFFE00u) >> 9u); }

int GetCookie() const { return static_cast<int>((this->num_outgoing_and_cookie_ & 0xFFFFFE00u) >> 9U); }

github-actions · 2026-10-20T20:49:20Z


  void SetCookie(int value) {
-    this->num_outgoing_and_cookie_ = (this->num_outgoing_and_cookie_ & 0x1FF) | (uint32_t)(value << 9);
+    this->num_outgoing_and_cookie_ = (this->num_outgoing_and_cookie_ & 0x1FFu) | (static_cast<uint32_t>(value) << 9u);


warning: integer literal has suffix 'u', which is not uppercase [hicpp-uppercase-literal-suffix]

Suggested change

this->num_outgoing_and_cookie_ = (this->num_outgoing_and_cookie_ & 0x1FFu) | (static_cast<uint32_t>(value) << 9u);

this->num_outgoing_and_cookie_ = (this->num_outgoing_and_cookie_ & 0x1FFU) | (static_cast<uint32_t>(value) << 9u);

github-actions · 2026-10-20T20:49:20Z


  void SetCookie(int value) {
-    this->num_outgoing_and_cookie_ = (this->num_outgoing_and_cookie_ & 0x1FF) | (uint32_t)(value << 9);
+    this->num_outgoing_and_cookie_ = (this->num_outgoing_and_cookie_ & 0x1FFu) | (static_cast<uint32_t>(value) << 9u);


warning: integer literal has suffix 'u', which is not uppercase [hicpp-uppercase-literal-suffix]

Suggested change

this->num_outgoing_and_cookie_ = (this->num_outgoing_and_cookie_ & 0x1FFu) | (static_cast<uint32_t>(value) << 9u);

this->num_outgoing_and_cookie_ = (this->num_outgoing_and_cookie_ & 0x1FFu) | (static_cast<uint32_t>(value) << 9U);

github-actions · 2026-10-20T20:49:20Z

 #define KEYVI_DICTIONARY_FSA_INTERNAL_SPARSE_ARRAY_BUILDER_H_

+#include <iostream>  // NOLINT(misc-include-cleaner)
+


warning: included header iostream is not used directly [misc-include-cleaner]

Suggested change

github-actions

clang-tidy made some suggestions

github-actions · 2026-10-21T05:51:46Z

      return "";
    } else {
-      return predictor_table_[(uint16_t(bigram[0]) << 8) + bigram[1]];
+      return predictor_table_[(static_cast<unsigned>(bigram[0]) << 8U) + bigram[1]];


warning: do not use array subscript when the index is not an integer constant expression [cppcoreguidelines-pro-bounds-constant-array-index]

return predictor_table_[(static_cast<unsigned>(bigram[0]) << 8U) + bigram[1]]; ^

github-actions · 2026-10-21T05:51:46Z

      return "";
    } else {
-      return predictor_table_[(uint16_t(bigram[0]) << 8) + bigram[1]];
+      return predictor_table_[(static_cast<unsigned>(bigram[0]) << 8U) + bigram[1]];


warning: do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic]

return predictor_table_[(static_cast<unsigned>(bigram[0]) << 8U) + bigram[1]]; ^

github-actions · 2026-10-21T05:51:46Z

      return "";
    } else {
-      return predictor_table_[(uint16_t(bigram[0]) << 8) + bigram[1]];
+      return predictor_table_[(static_cast<unsigned>(bigram[0]) << 8U) + bigram[1]];


warning: do not use pointer arithmetic [cppcoreguidelines-pro-bounds-pointer-arithmetic]

return predictor_table_[(static_cast<unsigned>(bigram[0]) << 8U) + bigram[1]]; ^

github-actions Bot reviewed Oct 20, 2026

View reviewed changes

hendrikmuhs force-pushed the fix-cpp-lint-2 branch 2 times, most recently from 7a43caf to b0744bb Compare October 20, 2026 20:29

github-actions Bot reviewed Oct 20, 2026

View reviewed changes

hendrikmuhs force-pushed the fix-cpp-lint-2 branch from b0744bb to 32447e5 Compare October 21, 2026 05:43

github-actions Bot reviewed Oct 21, 2026

View reviewed changes

Fix more cpplint and clang-tidy issues

0349dc5

hendrikmuhs force-pushed the fix-cpp-lint-2 branch from 32447e5 to 0349dc5 Compare October 21, 2026 05:54

hendrikmuhs merged commit 7e5f5a9 into KeyviDev:master Oct 21, 2026
23 of 24 checks passed

hendrikmuhs deleted the fix-cpp-lint-2 branch October 21, 2026 06:38

	uint16_t index = (static_cast<uint16_t>(c) << 8) + static_cast<uint16_t>(instream.get());
	uint16_t const index = (static_cast<uint16_t>(c) << 8) + static_cast<uint16_t>(instream.get());

	inline void Set(const size_t bit) { bits_[bit >> 6] \|= static_cast<uint64_t>(1) << (bit & 63); }
	void Set(const size_t bit) { bits_[bit >> 6] \|= static_cast<uint64_t>(1) << (bit & 63); }

	const uint16_t index = ((static_cast<unsigned>(c) & 0xFFu) << 8) + instream.get();
	const uint16_t index = ((static_cast<unsigned>(c) & 0xFFU) << 8) + instream.get();

	return predictor_table_[(static_cast<unsigned>(bigram[0]) << 8u) + bigram[1]];
	return predictor_table_[(static_cast<unsigned>(bigram[0]) << 8U) + bigram[1]];

	void Erase(const size_t bit) { bits_[bit >> 6u] &= static_cast<uint64_t>(~(1ULL << (bit & 63u))); }
	void Erase(const size_t bit) { bits_[bit >> 6U] &= static_cast<uint64_t>(~(1ULL << (bit & 63u))); }

	return (bits_[bit >> 6u] & (static_cast<uint64_t>(1) << (bit & 63u))) != 0;
	return (bits_[bit >> 6U] & (static_cast<uint64_t>(1) << (bit & 63u))) != 0;

	: offset_(offset), hashcode_(hashcode), num_outgoing_and_cookie_(static_cast<uint32_t>(num_outgoing) & 0x1FFu) {}
	: offset_(offset), hashcode_(hashcode), num_outgoing_and_cookie_(static_cast<uint32_t>(num_outgoing) & 0x1FFU) {}

	int GetNumberOfOutgoingTransitions() const { return static_cast<int>(this->num_outgoing_and_cookie_ & 0x1FFu); }
	[[nodiscard]] int GetNumberOfOutgoingTransitions() const { return static_cast<int>(this->num_outgoing_and_cookie_ & 0x1FFu); }

	int GetCookie() const { return static_cast<int>((this->num_outgoing_and_cookie_ & 0xFFFFFE00u) >> 9u); }
	[[nodiscard]] int GetCookie() const { return static_cast<int>((this->num_outgoing_and_cookie_ & 0xFFFFFE00u) >> 9u); }

	this->num_outgoing_and_cookie_ = (this->num_outgoing_and_cookie_ & 0x1FFu) \| (static_cast<uint32_t>(value) << 9u);
	this->num_outgoing_and_cookie_ = (this->num_outgoing_and_cookie_ & 0x1FFU) \| (static_cast<uint32_t>(value) << 9u);

		#define KEYVI_DICTIONARY_FSA_INTERNAL_SPARSE_ARRAY_BUILDER_H_

		#include <iostream> // NOLINT(misc-include-cleaner)

Conversation

hendrikmuhs commented Oct 20, 2026

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Oct 20, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Oct 20, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Oct 20, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Oct 20, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Oct 20, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Oct 20, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Oct 20, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Oct 20, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Oct 20, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Oct 20, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Oct 20, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Oct 20, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Oct 20, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Oct 20, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Oct 20, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Oct 20, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Oct 20, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Oct 20, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Oct 20, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Oct 20, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Oct 20, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Oct 20, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Oct 20, 2026

Choose a reason for hiding this comment