V17/image upload mapper#959
Merged
Merged
Conversation
…dia slightly diffrently)
Contributor
There was a problem hiding this comment.
Pull request overview
This PR separates image cropper and image upload value mapping so croppers continue to use JSON cropper payloads while upload fields remain plain strings.
Changes:
- Introduces a shared
ImagePathMapperBasefor media path rewriting and dependency discovery. - Narrows
ImagePathMapperto image cropper editors and addsImageUploadMapperfor upload fields. - Updates block JSON expansion behavior and bumps selected Umbraco package versions/schema outputs.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
uSync.Core/Mapping/Mappers/ImagePathMapperBase.cs |
Adds shared media path and dependency handling for image-related mappers. |
uSync.Core/Mapping/Mappers/ImagePathMapper.cs |
Refactors cropper mapper to inherit shared logic and only target image cropper editors. |
uSync.Core/Mapping/Mappers/ImageUploadMapper.cs |
Adds upload-field mapper that preserves plain string upload paths. |
uSync.Core/Mapping/SyncBlockMapperBase.cs |
Expands nested JSON strings during import property conversion. |
Directory.Packages.props |
Bumps selected Umbraco package versions. |
uSync.Tests/packages.lock.json |
Updates requested Umbraco.Cms version in the test lock file. |
uSync.Tests/appsettings-schema.json |
Regenerates schema text with escaped Unicode sequences. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splits the imageCropper and ImageUploadMapper into two different mappers.