Only require JIXIA_PATH for the subcommand that uses it - #31
Merged
Conversation
database/__main__.py read os.environ["JIXIA_PATH"] at import time, so schema, informal and vector-db all failed with KeyError even though none of them shell out to the jixia binary. Guard the assignment, and have the jixia subcommand validate the variable itself with a message that says what to set it to, instead of surfacing a bare KeyError.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
database/__main__.pyreados.environ["JIXIA_PATH"]at import time, soschema,informal, andvector-dball died withKeyError: 'JIXIA_PATH'— none of which shell out to the jixia binary. Only thejixiasubcommand needs it.This blocked running any of those commands standalone (it came up while re-embedding the ChromaDB index by hand).
What
jixiasubcommand validate the variable itself, with a message naming what to set it to rather than a bareKeyError.Verified