Fix the two failures blocking PhyslibAlpha and QuantumInfo - #30
Merged
Conversation
The forced run built PhyslibAlpha fine but failed the load for two reasons. QuantumInfo had no .olean files. The lake cache restored from physlib-lake-<sha>, a build made when only Physlib was compiled, and lake then considered the tree up to date, so QuantumInfo was never built and jixia failed 33 times with "object file does not exist". My previous attempt at this put the workflow hash in the key but left a bare physlib-lake- restore-key, which matched that older cache anyway. Namespace the key by the workflow hash first and keep the restore-key inside that namespace. An anonymous declaration aborted the whole load with IndexError: jixia's is_internal indexes name[-1] without checking for an empty name. Wrap it once so every call site is covered rather than guarding the one that happened to crash, and treat nameless entries as internal since they cannot be stored or searched for anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The forced run got PhyslibAlpha built and analysed, then failed the load for two separate reasons.
1. QuantumInfo had no
.oleanfiles (33 errors)The lake cache restored from
physlib-lake-<sha>— a build made back when onlyPhyslibwas compiled. Lake then considered the tree up to date, soQuantumInfowas never built.Build PhysLibreported "Build completed successfully (9396 jobs)" with zeroBuilt QuantumInfo.*lines.My previous attempt put the workflow hash in the cache key but left a bare
physlib-lake-restore-key, which matched that older cache anyway — so the fix did nothing. Now the key is namespaced by the workflow hash first and the restore-key stays inside that namespace.2. An anonymous declaration aborted the entire load
jixia's
is_internalindexesname[-1]without checking for an empty name. Wrapped once at the import so all four call sites are covered, rather than guarding only the one that happened to crash.Verified
Plus: module compiles, YAML parses.