Task5#152
Conversation
Implemented proc and sys convering word into uppercase and lower case Signed-off-by: Anton Kotsiubailo <antohakotsubailo@gmail.com>
| return -EINVAL; | ||
| } | ||
|
|
||
| res = class_create_file(x_class, &class_attr_total_characters_processed); |
There was a problem hiding this comment.
Checkpatch complains on this line as too long. Please split it.
| class_remove_file(x_class, &class_attr_xxx); | ||
| class_destroy(x_class); | ||
|
|
||
| return; |
There was a problem hiding this comment.
Remove this return, remove then empty line
There was a problem hiding this comment.
Have minor comments, all other works for me
alexposukhov
added
Change requested
Performed refactoring of existed code Signed-off-by: Anton Kotsiubailo <antohakotsubailo@gmail.com>
ant112342
added
Ready for review
|
|
||
|
|
||
| Please refer to wiki for details. | ||
| ======= |
There was a problem hiding this comment.
This file should NOT be modified.
There was a problem hiding this comment.
This is in YOUR pull request, so it somehow happened, probably by mistake.
Now you need to remove this extra change.
In order to do it - you have to inspect all your commits and find the problematic one.
Then do interactive rebase with stop on the problematic commit and fix it.
| pr_err("bad file 'total_characters_processed' create\n"); | ||
| return -EINVAL; | ||
| } | ||
|
|
||
| res = class_create_file(x_class, &class_attr_total_calls); | ||
| if (res != 0) { | ||
| pr_err("bad file 'total_calls' create\n"); | ||
| return -EINVAL; | ||
| } | ||
|
|
||
| res = class_create_file(x_class, &class_attr_characters_converted); | ||
| if (res != 0) { | ||
| pr_err("bad file 'characters_converted' create\n"); | ||
| return -EINVAL; |
There was a problem hiding this comment.
In case of error - Need to destroy previously created files and classes.
There was a problem hiding this comment.
Done, but I think README was changed, because previous this branch was deleted
I don't know why
There was a problem hiding this comment.
Still not done :(
Please read previous comment carefully!
Anton-Soroka
added
Change requested
ant112342
added
Ready for review
| else | ||
| # normal makefile | ||
|
|
||
| obj-m := task05_sys.o |
There was a problem hiding this comment.
You have two modules in this task.
Need to do following: either add line for second module here or add a separate makefile for each module.
Anton-Soroka
left a comment
Anton-Soroka
left a comment
There was a problem hiding this comment.
Previous comments still not resolved.
Please read carefully.
Anton-Soroka
added
Change requested
Implemented Makefile and added it to task05. Signed-off-by: Anton Kotsiubailo <antohakotsubailo@gmail.com>
ant112342
added
Ready for review
4 participants
Done task05