Skip to content

fix bus signal chevrons issue in https://github.com/KenKundert/psf_utils/pull/23 - #24

Merged
KenKundert merged 4 commits into
KenKundert:masterfrom
circuitmuggle:fast_read_trans_optimization
Dec 4, 2025
Merged

fix bus signal chevrons issue in https://github.com/KenKundert/psf_utils/pull/23 #24
KenKundert merged 4 commits into
KenKundert:masterfrom
circuitmuggle:fast_read_trans_optimization

Conversation

@circuitmuggle

@circuitmuggle circuitmuggle commented Dec 2, 2025

Copy link
Copy Markdown
Contributor

For bus signal, I saw the below error.

[Error] Failed to parse PSF for sweep_0.5V: 'I48.LOGIC_OUT<3>'

this pull request fix this issue at row 172 of psf.py

clean_name = name.replace('\\', '')
values[clean_name] = v_obj

I will add a tox test case in the future when I have bandwidth

…rs (like < and >) in the VALUE section (e.g., I48.LOGIC_OUT\<3\>), but the TRACE section and the internal signal names use the unescaped version (I48.LOGIC_OUT<3>).
@circuitmuggle circuitmuggle changed the title fix bus signal eliminator issue in https://github.com/KenKundert/psf_utils/pull/23 fix bus signal delimiter issue in https://github.com/KenKundert/psf_utils/pull/23 Dec 2, 2025
@circuitmuggle
circuitmuggle force-pushed the fast_read_trans_optimization branch from 1b66e8b to b2dc127 Compare December 2, 2025 01:51
@circuitmuggle

Copy link
Copy Markdown
Contributor Author

add test case[1] bus_chevrons_tran in tox to detect such failure

@circuitmuggle circuitmuggle changed the title fix bus signal delimiter issue in https://github.com/KenKundert/psf_utils/pull/23 fix bus signal chevrons issue in https://github.com/KenKundert/psf_utils/pull/23 Dec 4, 2025
@KenKundert
KenKundert merged commit a00619c into KenKundert:master Dec 4, 2025
3 checks passed
@KenKundert

Copy link
Copy Markdown
Owner

Thank you. Let me know when you think things are really stable.

@circuitmuggle

Copy link
Copy Markdown
Contributor Author

Hi Ken,

Thank you for your reply. I totally agreed with you that we should wait a while until the code is stable before releasing it to pypi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants