Skip to content

Add the missing [model] section to moe_small.toml - #199

Merged
Naeemkh merged 1 commit into
mainfrom
fix/moe-small-model-section
Sep 8, 2026
Merged

Add the missing [model] section to moe_small.toml#199
Naeemkh merged 1 commit into
mainfrom
fix/moe-small-model-section

Conversation

@Naeemkh

@Naeemkh Naeemkh commented Sep 2, 2026

Copy link
Copy Markdown
Member

Summary

  • configs/model/moe_small.toml was missing its [model] header, so its 13 keys landed at the top level of JobConfig and were rejected with Unknown config keys. It is the only one of four model presets that fails to load.

Testing

  • uv run ruff check kempnerforge/ tests/ passes
  • uv run ruff format --check kempnerforge/ tests/ scripts/ passes
  • uv run pyright kempnerforge/ passes (0 errors)
  • uv run pytest tests/unit/ -v --timeout=60 passes
  • If distributed code changed: uv run torchrun --nproc_per_node=4 -m pytest tests/distributed/ -v
  • If training loop / parallelism / optimizers changed: uv run pytest tests/e2e/ --e2e -v

@Naeemkh
Naeemkh requested review from amazloumi and mmshad September 2, 2026 20:25
@codecov

codecov Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Naeemkh
Naeemkh merged commit 1cd82e3 into main Sep 8, 2026
4 checks passed
@Naeemkh
Naeemkh deleted the fix/moe-small-model-section branch September 8, 2026 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants