Repository navigation
KSM-841: fix delete() skipping keys with falsy values in Oracle storage - #969
Merged
stas-schaller merged 1 commit intoMar 16, 2026
Conversation
stas-schaller
merged commit Mar 16, 2026
c35ee19
into
release/storage/javascript/oracle-kms/v1.0.0
3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
OciKeyValueStore.delete()silently skipping deletion when a key holds a falsy value ("",0,false).Root Cause
delete()usedif (config[key])(truthy check) instead ofif (key in config)(existence check). Keys with falsy values routed into theelsebranch — the key was never removed and the logger incorrectly reported "Key not found".Same bug was fixed in Azure (KSM-835), AWS (KSM-839), and GCP (KSM-840).
contains()was already corrected for Oracle in KSM-838.Changes
sdk/javascript/packages/oracle/src/OracleKeyValueStore.ts: Replaceif (config[key])→if (key in config)(line 433)sdk/javascript/packages/oracle/test/OracleKeyValueStore.test.ts: Adddescribe('delete() — KSM-841 regression')with 3 tests (empty string, zero, truly missing key)Test Plan
Regression tests confirmed failing before fix, passing after fix.
Closes https://keeper.atlassian.net/browse/KSM-841