Repository navigation
KSM-839: fix AwsKeyValueStore.delete() skipping keys with falsy values - #967
Merged
stas-schaller merged 1 commit intoMar 16, 2026
Conversation
stas-schaller
merged commit Mar 16, 2026
28d6e5f
into
release/storage/javascript/aws-kms/v1.0.0
3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AwsKeyValueStore.delete()used a truthy check (if (config[key])) to determine whether a key exists before deleting it. Any key holding a falsy value ("",0,false,null) silently survived the delete call — the key persisted in storage and the logger falsely reported "Key not found." Fix applies the samekey in configpattern already used bycontains()(fixed in KSM-836).Changes
Bug Fixes
if (config[key])withif (key in config)so keys holding"",0,false, ornullare correctly deletedTesting
All 50 tests pass, including 3 new regression tests covering empty-string values, numeric zero values, and truly missing keys.
Breaking Changes
None.
Related Issues