Repository navigation
JavaScript AWS KMS Storage: security dependency updates (KSM-1219) - #1168
Merged
mgallego-keeper merged 4 commits intoSep 16, 2026
Conversation
…-parser - Bumps the AWS SDK far enough that fast-xml-parser drops out of the dependency tree entirely (CVE-2026-41650) - the strongest fix available, the dependency is gone rather than patched - handlebars -> 4.7.9 (CVE-2026-33938, CVE-2026-33941) - dev-only via ts-jest - @babel/core -> 7.29.7 (CVE-2026-49356) - dev-only Also picks up two adjacent fixes from the same lockfile regeneration that weren't cleanly separable via cherry-pick: a minimatch brace-expansion ReDoS fix (VM-2511) and a fast-xml-builder fix (VM-2539), both lockfile-only. Took the final package-lock.json/yarn.lock state from Sergey Aldoukhov's unmerged vm-sast-batch-1 branch (commits 831b7b48, 28af7fea, 95cf4fe5, ca69e44b, efde007d) rather than cherry-picking individually - the AWS SDK bump's diff isn't independent of the two intermediate commits it builds on. KSM-1219
…ansion, picomatch and related transitive advisories
CI only ever runs npm ci; yarn.lock hasn't been read by any workflow and only exists because it was present in the package's first commit in 2021. Dependabot scanned it as a second manifest, double-counting every CVE in this package. No other JS storage package has one.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
stas-schaller
force-pushed
the
feature/KSM-1219-security-version-bumps-aws-kms
branch
from
September 16, 2026 16:18
1ed6e71 to
22f686d
Compare
mgallego-keeper
approved these changes
Sep 16, 2026
mgallego-keeper
left a comment
mgallego-keeper
left a comment
Contributor
There was a problem hiding this comment.
Security review.
This review checked the dependency bump for supply-chain integrity and CVE-fix completeness, and separately reviewed the yarn.lock removal.
What I verified:
npm auditon the pre-change lockfile found 13 vulnerabilities. The post-change lockfile has 0. I ran both audits myself.fast-xml-parserandfast-xml-builderare both fully removed from the tree, not just bumped. Both sat on the real production install path through@aws-sdk/client-kms, so this fix has genuine production value.- Every changed lockfile entry resolves to
https://registry.npmjs.org/with a matching integrity hash. I checked this exhaustively. - The
yarn.lockremoval is safe. No workflow, script, or document anywhere in the repository reads it. No other JS storage package has ever had one of its own. package.jsonis unchanged.npm cisucceeds cleanly with 551 packages installed.
One item for a separate follow-up, not blocking this PR:
package.json still contains "overrides": { "fast-xml-parser": "5.5.9" }, below the patched threshold of 5.7.0. This predates this PR and is currently inactive, since nothing in the tree needs fast-xml-parser anymore. If a future change reintroduces a dependency on it, this override would force it back to the vulnerable version. Please remove or update this override in a follow-up change. Filed as a separate ticket.
Verdict: no changes requested on this PR's own diff.
mgallego-keeper
marked this pull request as ready for review
September 16, 2026 17:07
mgallego-keeper
merged commit Sep 16, 2026
83c6d4d
into
release/storage/javascript/aws-kms/v1.0.1
3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JavaScript AWS KMS Storage: updates js-yaml, handlebars, brace-expansion, and other transitive dependencies to resolve every open Dependabot advisory on this package's
package-lock.json, and removes an unusedyarn.lock.Changes
Maintenance
package-lock.jsonvianpm audit fix.package.jsonunchanged; every affected package resolves within its existing declared range.yarn.lock. Both CI workflows for this package (test and publish) runnpm cionly. The file dated back to the package's first commit in 2021 and was never read by anything, but Dependabot scanned it as a second manifest and double-counted every CVE in this package.Testing
Breaking Changes
None.
Related Issues
Draft, not ready to merge. This branch needs
@keeper-security/secrets-manager-corebumped to v17.6.0 once that release publishes. Its range (^17.3.0) already allows 17.6.0; it's just not out yet. Opening as a draft now so review on the dependency fixes isn't blocked on that.