Repository navigation
Test tooling: harden subprocess and path handling in Ruby SDK and Azure DevOps scripts (KSM-1244) - #1138
Merged
maksimu merged 1 commit intoAug 31, 2026
Conversation
stas-schaller
changed the title
stas-schaller
force-pushed
the
feature/KSM-1244-ruby-docker-test-shell-injection
branch
from
August 31, 2026 16:21
8d9884e to
cf12348
Compare
stas-schaller
changed the title
…244) Ruby SDK's docker_test_suite.rb, docker_multi_version_test.rb, and run_all_tests.rb interpolated build/run/cleanup values into system()/backtick calls, which Ruby runs through /bin/sh -c. Switched to array-form system() and IO.popen, which pass each argument directly to the binary with no shell involved. Azure DevOps extension's run-tests.sh passed an unquoted $(pwd) into the docker run -v flag, letting word-splitting or glob expansion break the mount argument on a path with a space or glob character. Quoted the substitution.
stas-schaller
force-pushed
the
feature/KSM-1244-ruby-docker-test-shell-injection
branch
from
August 31, 2026 16:39
cf12348 to
f5b9b82
Compare
stas-schaller
changed the title
mgallego-keeper
approved these changes
Aug 31, 2026
stas-schaller
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ruby SDK: hardens how the Docker/integration test-runner scripts invoke subprocesses. Azure DevOps extension: hardens a path substitution in its test runner. Both are dev/CI tooling only, not shipped in a published artifact, so no version bump is needed for either component.
Changes
Maintenance
sdk/ruby/test/integration/docker_test_suite.rb,docker_multi_version_test.rb, andrun_all_tests.rb: switched subprocess invocations from interpolated shell strings to array-formsystem()/IO.popen(), which pass each argument directly to the binary with no shell involved (KSM-1244)integration/keeper_secrets_manager_azure_pipeline_extension/ksm-azure-devops-secrets-task/tests/run-tests.sh: quoted a command substitution in adocker runmount argument so it isn't word-split or glob-expanded (KSM-1244)Testing
Breaking Changes
None.
Related Issues