Skip to content

KC-1457: Block Service Mode from ever accessing its own config records - #2381

Merged
sk-keeper merged 1 commit into
releasefrom
add/restrict-sm-config-records
Sep 18, 2026
Merged

sk-keeper merged 1 commit into
releasefrom
add/restrict-sm-config-records

Conversation

@amangalampalli-ks

Copy link
Copy Markdown
Contributor

Summary

Blocks Service Mode from ever reading, editing, resharing, or deleting its own two config records ("Commander Service Mode Config" and "Commander Service Mode Docker Config"), no matter which command or how it's used.

Changes

  • Reject any Service Mode command whose arguments reference either config record by name or by ID.
  • Hide both records from the vault data while a command runs, so they can't surface indirectly either.
  • Applied to every command, not a specific list, so new commands added later are covered automatically.
  • None of this affects normal Commander usage outside of Service Mode — it only applies to commands run through the Service Mode API.

#2372)

* Block Service Mode from ever accessing its own config records

* Fix copilot review comments

* Fix claude review comments

* Fix review comments
@amangalampalli-ks amangalampalli-ks self-assigned this Sep 18, 2026
@amangalampalli-ks
amangalampalli-ks marked this pull request as ready for review September 18, 2026 17:32
@sk-keeper
sk-keeper merged commit 20b43e9 into release Sep 18, 2026
4 checks passed
@sk-keeper
sk-keeper deleted the add/restrict-sm-config-records branch September 18, 2026 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants