KC-1458: Restrict app-setup command lists to their own allowlist - #2376
Merged
Merged
Conversation
* Restrict app-setup command lists to their own allowlist * Add nsf-move command to terraform-app-setup command list * Handle empty string case * Fix review comments
sk-keeper
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Each integration via
*-app-setupcommands (Slack, Teams, Google Chat, Terraform) now enforces its own declared command list both when the setup command generates the docker-compose file and again every time the container starts, closing the gap where a modified or outdated configuration could grant extra commands. SailPoint already had protection against this; the other integrations did not.Changes