Skip to content

KC-1458: Restrict app-setup command lists to their own allowlist - #2376

Merged
sk-keeper merged 1 commit into
releasefrom
add/restrict-app-setup-command-list
Sep 18, 2026
Merged

sk-keeper merged 1 commit into
releasefrom
add/restrict-app-setup-command-list

Conversation

@amangalampalli-ks

Copy link
Copy Markdown
Contributor

Summary

Each integration via *-app-setup commands (Slack, Teams, Google Chat, Terraform) now enforces its own declared command list both when the setup command generates the docker-compose file and again every time the container starts, closing the gap where a modified or outdated configuration could grant extra commands. SailPoint already had protection against this; the other integrations did not.

Changes

  • Extracted the sanitization logic that SailPoint already used into a shared, reusable mechanism so every integration benefits from the same protection without duplicating logic.
  • Added a fallback so this protection still applies to SailPoint even in cases where its own internal validation is skipped.
  • Added a warning for the unexpected case where a container ends up configured for more than one integration at once.
  • Add nsf-move command to terraform-app-setup command list

* Restrict app-setup command lists to their own allowlist

* Add nsf-move command to terraform-app-setup command list

* Handle empty string case

* Fix review comments
@amangalampalli-ks amangalampalli-ks self-assigned this Sep 18, 2026
@amangalampalli-ks
amangalampalli-ks marked this pull request as ready for review September 18, 2026 05:26
@sk-keeper
sk-keeper merged commit 724a0ff into release Sep 18, 2026
4 checks passed
@sk-keeper
sk-keeper deleted the add/restrict-app-setup-command-list branch September 18, 2026 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants