KC-1457: Block Service Mode from ever accessing its own config records - #2372
Merged
amangalampalli-ks merged 4 commits intoSep 18, 2026
Merged
amangalampalli-ks merged 4 commits into
amangalampalli-ks merged 4 commits into
Conversation
pvagare-ks
approved these changes
Sep 18, 2026
amangalampalli-ks
force-pushed
the
add/restrict-sm-config-records-int
branch
2 times, most recently
from
September 18, 2026 06:16
3168cfa to
45c2764
Compare
sali-ks
approved these changes
Sep 18, 2026
amangalampalli-ks
force-pushed
the
add/restrict-sm-config-records-int
branch
from
September 18, 2026 17:13
45c2764 to
c9fd1c5
Compare
amangalampalli-ks
merged commit Sep 18, 2026
2681c40
into
add/restrict-sm-config-records
4 checks passed
sk-keeper
pushed a commit
that referenced
this pull request
Sep 18, 2026
#2372) * Block Service Mode from ever accessing its own config records * Fix copilot review comments * Fix claude review comments * Fix review comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Blocks Service Mode from ever reading, editing, resharing, or deleting its own two config records ("Commander Service Mode Config" and "Commander Service Mode Docker Config"), no matter which command or how it's used.
Changes