Skip to content

KC-1464: allow renaming root node #2371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sk-keeper merged 1 commit into from
Sep 16, 2026
+49 −1
Merged

KC-1464: allow renaming root node #2371

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion keepercommander/commands/enterprise.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1554,7 +1554,9 @@ def is_in_chain(node_id, parent_id):
'node_id': node['node_id'],
'encrypted_data': encrypted_data
}
rq['parent_id'] = parent_id if parent_id else node.get('parent_id')
effective_parent_id = parent_id if parent_id else node.get('parent_id')
if effective_parent_id:
rq['parent_id'] = effective_parent_id
request_batch.append(rq)

if request_batch:
Expand Down
46 changes: 46 additions & 0 deletions unit-tests/test_command_enterprise.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,52 @@ def test_enterprise_info_users_verbose_returns_ids(self):
'role_name': ent_env.role1_name,
}])

def test_enterprise_node_rename_root_omits_parent_id(self):
params = get_connected_params()
api.query_enterprise(params)
cmd = enterprise.EnterpriseNodeCommand()

with mock.patch('keepercommander.commands.enterprise.api.execute_batch',
return_value=[{'result': 'success'}]) as execute_batch:
cmd.execute(params, node=[str(ent_env.node1_id)], displayname='Renamed Enterprise')

request = execute_batch.call_args.args[1][0]
self.assertNotIn('parent_id', request)
data = crypto.decrypt_aes_v1(
utils.base64_url_decode(request['encrypted_data']),
params.enterprise['unencrypted_tree_key'],
)
self.assertEqual(json.loads(data.decode('utf-8'))['displayname'], 'Renamed Enterprise')

def test_enterprise_node_rename_child_preserves_parent_id(self):
params = get_connected_params()
api.query_enterprise(params)
cmd = enterprise.EnterpriseNodeCommand()

with mock.patch('keepercommander.commands.enterprise.api.execute_batch',
return_value=[{'result': 'success'}]) as execute_batch:
cmd.execute(params, node=[str(ent_env.node2_id)], displayname='Renamed Child')

request = execute_batch.call_args.args[1][0]
self.assertEqual(request['parent_id'], ent_env.node1_id)
data = crypto.decrypt_aes_v1(
utils.base64_url_decode(request['encrypted_data']),
params.enterprise['unencrypted_tree_key'],
)
self.assertEqual(json.loads(data.decode('utf-8'))['displayname'], 'Renamed Child')

def test_enterprise_node_move_sets_selected_parent_id(self):
params = get_connected_params()
api.query_enterprise(params)
cmd = enterprise.EnterpriseNodeCommand()

with mock.patch('keepercommander.commands.enterprise.api.execute_batch',
return_value=[{'result': 'success'}]) as execute_batch:
cmd.execute(params, node=[str(ent_env.node2_id)], parent=str(ent_env.node1_id))

request = execute_batch.call_args.args[1][0]
self.assertEqual(request['parent_id'], ent_env.node1_id)

def test_enterprise_add_user(self):
params = get_connected_params()
api.query_enterprise(params)
Expand Down
Loading