ci: publish immutable Commander image for KiaB - #2332
booker-keeper wants to merge 4 commits into
Conversation
Every other Keeper ECR-publish PR (database-updater, vault, push, keeperapp) makes this step warn-only with the same stated reason: findings are unmeasured. This step had exit-code: '1' with no continue-on-error, making it an actual blocking gate. python:3.11-slim almost certainly carries unfixed HIGH/CRITICAL findings, so this would very likely fail the very first real publish run, unlike the deliberate choice documented in every sibling repo's workflow.
|
Fix: Trivy scan was a real blocking gate, unlike every sibling ECR-publish workflow. The
Fixed in 8f5edb2 — added |
Verified against the real Commander source (clone + grep across keepercommander/*.py, params.py's Params.__init__/server setter, and __main__.py's --server arg): no such gate exists anywhere in the codebase. --server / config.json's "server" field is a plain, ungated string; Params never checks any ALLOW_CUSTOM_SERVER-shaped variable. The entrypoint script was conditionally exporting an env var that Commander never reads -- not a live bug (an unused env var can't break anything), but misleading: it implies custom-server usage is gated when it never was. Removed.
|
Fix: removed dead Cloned
(For contrast: |
Summary
Add a GA-ready Docker/ECR publication workflow for Keeper Commander so it can be included as an optional Keeper-in-a-Box bundle artifact.
Changes
commanderECR repository.config.kiab.example.jsontemplate.KEEPER_SERVERinstead of baking an endpoint into the image.Runtime configuration
The image does not bake in cloud or KiaB endpoints. Operators provide a config file or
KEEPER_SERVERat runtime. KiaB can mount a config containinglocal.keepersecurity.com; cloud deployments can use the default or a normal Commander config.