Skip to content

add unsafe flag for apply-membership #2326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lthievenaz-keeper wants to merge 2 commits into from
Closed

add unsafe flag for apply-membership #2326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45e2c0e
Add unsafe flag to ApplyMembership
lthievenaz-keeper Aug 27, 2026
fc9b3cc
Support unsafe flag for ApplyMembership
lthievenaz-keeper Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion keepercommander/importer/commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,7 @@ def register_command_info(aliases, command_info):

apply_membership_parser = argparse.ArgumentParser(prog='apply-membership', description='Loads shared folder membership from JSON file')
apply_membership_parser.add_argument('--full-sync', dest='full_sync', action='store_true', help='Update and remove membership also.')
apply_membership_parser.add_argument('--unsafe', dest='unsafe', action='store_true', help='Combined with --full-sync. Will remove yourself from folders where you have no permission.')
apply_membership_parser.add_argument('name', type=str, nargs='?', help='Input file name. "shared_folder_membership.json" if omitted.')
apply_membership_parser.error = raise_parse_exception
apply_membership_parser.exit = suppress_exit
Expand Down Expand Up @@ -523,8 +524,9 @@ def execute(self, params, **kwargs):
teams.append(obj)

full_sync = kwargs.get('full_sync') is True
unsafe = kwargs.get('unsafe') is True
if len(shared_folders) > 0:
imp_exp.import_user_permissions(params, shared_folders, full_sync)
imp_exp.import_user_permissions(params, shared_folders, full_sync, unsafe)

if len(teams) > 0:
imp_exp.import_teams(params, teams, full_sync)
Expand Down
9 changes: 6 additions & 3 deletions keepercommander/importer/imp_exp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -617,7 +617,7 @@ def import_teams(params, teams, full_sync=False): # type: (KeeperParams, List[

def import_user_permissions(params,
shared_folders,
full_sync=False): # type: (KeeperParams, List[ImportSharedFolder], bool) -> None
full_sync=False, unsafe=False): # type: (KeeperParams, List[ImportSharedFolder], bool) -> None
if not shared_folders:
return

Expand Down Expand Up @@ -654,7 +654,7 @@ def import_user_permissions(params,

folders = [x for x in folders if x.uid in params.shared_folder_cache]
if folders:
permissions = prepare_folder_permission(params, folders, full_sync)
permissions = prepare_folder_permission(params, folders, full_sync, unsafe)
if permissions:
teams_added = 0
users_added = 0
Expand Down Expand Up @@ -2536,7 +2536,7 @@ def prepare_record_link(params, records):
return record_links


def prepare_folder_permission(params, folders, full_sync):
def prepare_folder_permission(params, folders, full_sync, unsafe=False):
# type: (KeeperParams, List[ImportSharedFolder], bool) -> list
"""Prepare a list of API interactions for changes to folder permissions."""
shared_folder_lookup = {}
Expand Down Expand Up @@ -2632,6 +2632,9 @@ def prepare_folder_permission(params, folders, full_sync):
existing_users.update((x['username'] for x in shared_folder['users']))
if params.user in existing_users:
existing_users.remove(params.user)
if unsafe:
# Set user to end of array to be removed last
existing_users.add(params.user)
keep_teams = set()
keep_users = set()

Expand Down
Loading