Repository navigation
fix: the ACL fragment comment keeps every line a comment - #8
Merged
Merged
Conversation
A line of the comment redis_acl_fragment writes into
/etc/redis/redis.conf.d/50-keel-secret.conf had lost its "#". The first
boot wrote it as it was, Redis read it as a directive and redis-server
refused to start ("Unresolved Configuration(s) Detected ... aborting"),
found by the headless boot of the Keel Redis 19.0-7 image.
tests/redis.bats: every line of the rendered fragment is a comment, a blank
or a user rule (it fails on the old text), and a real redis-server started
on the shipped 20-keel-acl.conf and the rendered fragment keeps running
until the timeout stops it. The workflow installs redis-server so the
second test runs in CI instead of skipping. unit-redis 1.0.4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lib/redis.sh:105: a line of the commentredis_acl_fragmentwrites into/etc/redis/redis.conf.d/50-keel-secret.confhad lost its#. Redis read it as a directive andredis-serverrefused to start ("Unresolved Configuration(s) Detected ... aborting"). Found by the headless boot of the Keel Redis 19.0-7 image, which is withdrawn.#is back.tests/redis.bats: every line of the rendered fragment is a comment, blank or auserrule (fails on the old text, checked); a realredis-serveron the shipped20-keel-acl.confplus the rendered fragment keeps running until a 3 s timeout (exit 124). The workflow installsredis-serverso this runs in CI instead of skipping.v1.0.4after merge.