Repository navigation
Raise the coverage threshold to 99, the measured number - #2
Merged
Merged
Conversation
tests/coverage.sh is on the default branch since pull request #1 and measures tkldev-setup 185 of 186 lines under kcov, 99.46 percent, 63 bats. The workflow now enforces that number and COVERAGE.md records it as the measured baseline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: the gate in .github/workflows/tests.yml still says 0 (nothing measured) although tests/coverage.sh is on the default branch since pull request #1 (merge commit 994ecf4).
Diagnosis: the bootstrap threshold was a placeholder until a coverage script existed (docs/ci-cd.md section 3).
Fix: threshold 99, the number the script measures rounded down (tkldev-setup 185 of 186 lines under kcov, 99.46 percent, 63 bats); COVERAGE.md gets a measured baseline section with the date and merge commit. Never lowered from here (decision 0006).
Tests: the required check runs tests/coverage.sh with COVERAGE_THRESHOLD=99 on the merge ref of this pull request.
Serves BRIEF section 10 (tests and coverage enforced in GitHub) and org-plan section 3 step 5.