Repository navigation
feat: the spec's cloud section and keel cloud (0046) - #68
Draft
marcos-mendez wants to merge 3 commits into
Draft
marcos-mendez wants to merge 3 commits into
marcos-mendez wants to merge 3 commits into
Conversation
The spec gains a cloud section, additive under version 1: endpoint (an https URL), api_key (skip or a file reference), entry_secret (a file reference), set (a lower case DNS label, required with a key) and ca_file. Secrets are file references only, never generate: the key is made by Keel Cloud and the entry secret by the set's first node. keel validates the section and diff never compares it; the peers Keel Cloud's node agent writes are compared under network.overlay as before. keel cloud runs keel-cloud-node of the keel-overlay-cloud package with the same arguments, and names the package when it is missing (exit 9). Proven on the test VM with Keel-Linux/keel-cloud: two Keel Core containers with this keel enrolled, gained each other as peers and brought the overlay up with spec apply --system and network confirm.
3 tasks
added 2 commits
October 2, 2026 14:13
# Conflicts: # debian/changelog # keel/__init__.py # pyproject.toml
A trailing newline passed the anchored patterns, so "shop\n" was a valid set name. Found in the security review of keel-cloud's Phase A.
Collaborator
Author
|
Paused by the maintainer (2026-10-02) until the etcd mesh (Phase 5 of tracker#46: registry, install by discovery, three nodes without Keel Cloud) is stable. Then the node-side client ships in images, small and disabled, and is enabled later through apt update and apt upgrade. Needs an independent security review before merge. |
marcos-mendez
marked this pull request as draft
October 2, 2026 14:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The spec gains a
cloudsection for Keel Cloud (handbook decision 0046, proposed in handbook#39), additive underversion: 1, andkeel cloudruns Keel Cloud's node agent from thekeel-overlay-cloudpackage of Keel-Linux/keel-cloud.cloud.endpoint(https only, no path),cloud.api_key(skipor a file reference),cloud.entry_secret(a file reference),cloud.set(a DNS label, required with a key),cloud.ca_file. Secrets are file references only, nevergenerate.diffreportscloud: not compared. The agent writesnetwork.overlay.wireguard.peers, whichspec apply --systemconverges anddiffcompares as before.keel cloud ...execskeel-cloud-node ...; without the package it says which package and exits 9.Tests:
tests/test_spec_cloud.py; the full suite passes locally at 99.8 percent. Used in the real test of keel-cloud's Phase A on the test VM (two Keel Core containers with this keel brought the overlay up through Keel Cloud).Test plan