Repository navigation
fix: drop the overlay's Keel source and 1001 pin; 990 everywhere - #16
Open
marcos-mendez wants to merge 3 commits into
Open
marcos-mendez wants to merge 3 commits into
marcos-mendez wants to merge 3 commits into
Conversation
added 2 commits
October 2, 2026 15:03
The overlay shipped /etc/apt/sources.list.d/keel.sources and /etc/apt/preferences.d/keel at 1001. At 1001 apt downgrades every package newer than the archive's (tracker#23), and at those paths both files override the source and the 990 pin Keel-Linux/common#30 ships. conf.d/zzz-keel-archive verifies common's two files and changes nothing, or writes the same ones on a bootstrap from before common shipped them, and refuses any pin but 990; it no longer turns every Enabled: no into yes, which would enable the testing track. The build time archive is pinned by its Label for the build only, removed by zz-project-packages, which fails if any apt file still names it. The boot test expects 990, reads the stable stanza only, and accepts a newer installed version apt keeps instead of downgrading.
3 of 5 tasks
require-changelog wants a new top entry, not a bullet in the base branch's.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Same change as the other six recipes, plus what is specific to this one, which ships its Keel source enabled.
/etc/apt/sources.list.d/keel.sourcesor/etc/apt/preferences.d/keel(Pin-Priority 1001). At 1001, apt downgrades every package newer than the archive's (tracker#23). COVERAGE.md had already measured keel-archive-keyring 0.1.1 going back to 0.1.0. At those paths, the overlay also wins over the source and the 990 pin that fix: images take packages from Debian and the Keel repository only common#30 ships.conf.d/zzz-keel-archivenow:trixie-testingdisabled, pin 990);sed 's/^Enabled: no$/Enabled: yes/'over the file, which on common's file would have enabled the testing track.conf.d/mainwrites/etc/apt/preferences.d/keel-staging(l=Keel Linux staging, 1001) before its upgrade, so the staging archive still wins over TurnKey's 999 pin during the build.conf.d/zz-project-packagesremoves it with the staging source, then fails if any apt file still names the build-time archive.keel.sources.bt_policy_verdictalso passes when apt keeps an installed project package that is newer than the archive's and comes from no other source. This is the no-downgrade case: at 1001 the candidate was the archive's older version.PR #15 conflict: a local test merge of
fix/configtest-at-first-bootinto this branch conflicts inCOVERAGE.mdonly (the coverage table and the totals).changelog,conf.d/main,tests/boot-test.batsandtests/lib/boot-test-lib.shmerge cleanly.Merge order: the seven recipes, then the pool, then common#30 together with inithooks#34.
Test plan
bats tests/: 239 tests pass. The new and changed tests were RED first.tests/coverage.sh 97: zzz-keel-archive 100 (37/37), zz-project-packages 100 (35/35), boot-test-lib.sh 99.32 (292/294)