Repository navigation
Read apt's *** marker when the installed version is the candidate - #13
Merged
Merged
Conversation
added 3 commits
September 30, 2026 02:22
bt_policy_verdict looked for the candidate as the first field of its version line, but apt prints the installed version as ' *** 2.3.6+keel5 1001', so a current appliance, whose installed version is the candidate, failed the check. The gate never reached it until tracker#5 was fixed on 2026-09-30; its first run past the archive failed here. The old fixture wrote two lines where apt writes one; the new test uses apt's real output and fails on the old code.
From the review of #13: the version line's number is the highest priority of its sources, so matching it proved nothing about where the candidate comes from; any repository claiming our origin gets our pin. The parse now requires '<pin> <uri>' inside the candidate's block, and a new test refuses an installed candidate from another source at the same pin.
kcov counted the lines of the inline awk program as unexecuted bash and put boot-test-lib.sh under the 97 percent gate. The program moves to tests/lib/candidate-source.awk, beside the library, with its explanation, and the library finds it through BT_LIB_DIR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The boot gate's first run that reached the archive (after Keel-Linux/tracker#5 was fixed on the public services VM, 2026-09-30) failed with
the candidate inithooks 2.3.6+keel5 does not come from https://archive.keellinux.org at priority 1001, although it does. apt prints the installed version as*** 2.3.6+keel5 1001, with both sources under it, andbt_policy_verdictcompared the version to the first field. The old fixture wrote two separate lines, which apt never does for an installed candidate. The new test is apt's real output from that run; it fails on the old code and passes on the new.