Skip to content

The three refutations in wrappers.bats that asserted nothing #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcos-mendez merged 1 commit into from
Sep 29, 2026
Merged

The three refutations in wrappers.bats that asserted nothing #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions tests/wrappers.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@
# it is run through a copy of the overlay made the way the build makes it
# (`cp -TdR`, which is what fab-apply-overlay executes).

bats_require_minimum_version 1.5.0

setup() {
REPO="$BATS_TEST_DIRNAME/.."
BIN="$REPO/overlay/usr/local/bin"
Expand Down Expand Up @@ -256,16 +258,16 @@ _runuser_command() {
KEEL_TEST_UID=1000 run "$UPDATE"
[ "$status" -eq 1 ]
[[ "$output" == *"keel-wordpress-update must run as root"* ]]
! grep -q '^wp ' "$CALLS"
run ! grep -q '^wp ' "$CALLS"
}

@test "keel-wordpress-update refuses a target that is not a WordPress" {
rm -f "$WPROOT/wp-includes/version.php"
run "$UPDATE"
[ "$status" -eq 1 ]
[[ "$output" == *"is not a WordPress installation"* ]]
! grep -q '^wp ' "$CALLS"
! grep -q '^chown ' "$CALLS"
run ! grep -q '^wp ' "$CALLS"
run ! grep -q '^chown ' "$CALLS"
}

@test "keel-wordpress-update updates core and then verifies the checksums" {
Expand All @@ -280,15 +282,15 @@ _runuser_command() {
run "$UPDATE"
[ "$status" -eq 1 ]
grep -q "^wp --allow-root --path=$WPROOT core update\$" "$CALLS"
! grep -q 'verify-checksums' "$CALLS"
run ! grep -q 'verify-checksums' "$CALLS"
}

@test "keel-wordpress-update stops when the checksums do not verify" {
KEEL_TEST_WP_FAIL="--allow-root --path=$WPROOT core verify-checksums" \
run "$UPDATE"
[ "$status" -eq 1 ]
grep -q "^wp --allow-root --path=$WPROOT core verify-checksums\$" "$CALLS"
! grep -q '^chown -R root:root' "$CALLS"
run ! grep -q '^chown -R root:root' "$CALLS"
}

@test "keel-wordpress-update puts the ownership boundary back" {
Expand Down Expand Up @@ -322,7 +324,7 @@ _runuser_command() {
USER=root run "$UPDATE"
[ "$status" -eq 0 ]
grep -q "^chown -R $WEB_USER:$WEB_USER $WPROOT/wp-content/uploads\$" "$CALLS"
! grep -q '^chown -R root:root .*wp-content' "$CALLS"
run ! grep -q '^chown -R root:root .*wp-content' "$CALLS"
grep -q "^chown root:$WEB_USER $WPROOT/wp-config.php\$" "$CALLS"
}

Expand All @@ -334,6 +336,6 @@ _runuser_command() {
WPROOT=/ WP_USER=root WP_CLI=/bin/true run "$UPDATE"
[ "$status" -eq 0 ]
grep -q "^chown -R root:root $KEEL_TEST_WPROOT\$" "$CALLS"
! grep -qx 'chown -R root:root /' "$CALLS"
run ! grep -qx 'chown -R root:root /' "$CALLS"
grep -q "^wp --allow-root --path=$KEEL_TEST_WPROOT core update\$" "$CALLS"
}
Loading