Skip to content

A negated command only asserts in final position #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcos-mendez merged 2 commits into from
Sep 29, 2026
Merged

A negated command only asserts in final position #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3030b83
test: a negated command only asserts in final position
marcos-mendez Sep 28, 2026
38c9d23
Merge remote-tracking branch 'origin/master' into test/negations-that…
Sep 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 18 additions & 16 deletions tests/boot-test.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
# and secret paths, and every verdict this appliance adds. lxc-info is a stub
# first in PATH; the clock and sleep are functions. No root, no network, no LXC.

bats_require_minimum_version 1.5.0

setup() {
LIB="$BATS_TEST_DIRNAME/lib/boot-test-lib.sh"
S="$BATS_TEST_TMPDIR"
Expand Down Expand Up @@ -97,10 +99,10 @@ setup() {
[ "$(bt_container_name wordpress)" = keel-wordpress-boot-test ]
bt_is_container_name demo.one
bt_is_container_name 9lives
! bt_is_container_name ".hidden"
! bt_is_container_name ""
run ! bt_is_container_name ".hidden"
run ! bt_is_container_name ""
bt_is_appliance_name wordpress
! bt_is_appliance_name 9wordpress
run ! bt_is_appliance_name 9wordpress
}

# --- addresses ---------------------------------------------------------------
Expand All @@ -112,12 +114,12 @@ setup() {
}

@test "is_global_ipv6 refuses link local, loopback, multicast and IPv4" {
! bt_is_global_ipv6 fe80::1
! bt_is_global_ipv6 FE80::1
! bt_is_global_ipv6 ::1
! bt_is_global_ipv6 ff02::1
! bt_is_global_ipv6 10.0.3.1
! bt_is_global_ipv6 ""
run ! bt_is_global_ipv6 fe80::1
run ! bt_is_global_ipv6 FE80::1
run ! bt_is_global_ipv6 ::1
run ! bt_is_global_ipv6 ff02::1
run ! bt_is_global_ipv6 10.0.3.1
run ! bt_is_global_ipv6 ""
}

@test "global_ipv6 takes the first global address from lxc-info output" {
Expand Down Expand Up @@ -157,7 +159,7 @@ EOF
@test "deadline_passed compares the elapsed time with the timeout" {
bt_deadline_passed 100 10 110
bt_deadline_passed 100 10 115
! bt_deadline_passed 100 10 105
run ! bt_deadline_passed 100 10 105
}

@test "wait_for returns as soon as the command succeeds" {
Expand Down Expand Up @@ -193,16 +195,16 @@ EOF

@test "is_ssh_banner accepts an OpenSSH banner and nothing else" {
bt_is_ssh_banner "SSH-2.0-OpenSSH_10.0p2 Debian-8"
! bt_is_ssh_banner "220 ready"
! bt_is_ssh_banner ""
run ! bt_is_ssh_banner "220 ready"
run ! bt_is_ssh_banner ""
}

@test "firstboot_done_in reads the flag 98finalize clears" {
printf 'RUN_FIRSTBOOT=true\n' > "$S/defaults"
! bt_firstboot_done_in "$S/defaults"
run ! bt_firstboot_done_in "$S/defaults"
printf 'RUN_FIRSTBOOT=false\n' > "$S/defaults"
bt_firstboot_done_in "$S/defaults"
! bt_firstboot_done_in "$S/nothing-here"
run ! bt_firstboot_done_in "$S/nothing-here"
}

# --- the container config and the container marks ----------------------------
Expand Down Expand Up @@ -404,9 +406,9 @@ EOF
@test "password_in_config compares the declared password with the one in the file" {
_config wordpress wordpress 'S3cret-value'
bt_password_in_config "$S/wp-config.php" 'S3cret-value'
! bt_password_in_config "$S/wp-config.php" 'something-else'
run ! bt_password_in_config "$S/wp-config.php" 'something-else'
printf "<?php\n" > "$S/wp-config.php"
! bt_password_in_config "$S/wp-config.php" 'S3cret-value'
run ! bt_password_in_config "$S/wp-config.php" 'S3cret-value'
}

# --- the login verdicts -----------------------------------------------------
Expand Down
4 changes: 3 additions & 1 deletion tests/hook.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
# library, so kcov measures the file the appliance ships. No test needs root, a
# database, a web server or a network.

bats_require_minimum_version 1.5.0

setup() {
REPO="$BATS_TEST_DIRNAME/.."
HOOK="$REPO/overlay/usr/lib/inithooks/firstboot.d/40wordpress"
Expand Down Expand Up @@ -144,7 +146,7 @@ EOF
grep -q "define('DB_NAME', 'wordpress');" "$WPROOT/wp-config.php"
grep -q "define('DB_USER', 'wordpress');" "$WPROOT/wp-config.php"
grep -q "define('DB_HOST', '\[::1\]');" "$WPROOT/wp-config.php"
! grep -q "turnkey" "$WPROOT/wp-config.php"
run ! grep -q "turnkey" "$WPROOT/wp-config.php"
}

@test "the password never reaches the command line of wp core install" {
Expand Down
Loading