Skip to content

Run the changelog check only where it can read the pull request #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcos-mendez merged 1 commit into from
Sep 27, 2026
Merged

Run the changelog check only where it can read the pull request #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,16 @@ jobs:
parent: core
timeout: 60
package:
# Only on a pull request. require-changelog compares the two commits of
# the pull request, which it reads from
# github.event.pull_request.base.sha; outside a pull request that is
# empty and the script is handed one argument instead of two, so every
# push to main failed the check. The keel repository already gates it
# this way. A job whose condition is false is reported as skipped,
# which satisfies a required status, so protection keeps working and
# the check is still a real run on the pull request itself, which is
# the only place it can say anything.
if: github.event_name == 'pull_request'
# This recipe has no debian/changelog: what bt-layer records in the
# manifest is the top entry of ./changelog, which is also what
# make-release-deb.py turns into the release package. So that is the
Expand Down
Loading