Repository navigation
Name the appliance check for what it proves - #12
Merged
Merged
Conversation
keel-linux/.github renames the reusable job build-and-boot to boot-published-layer, because the job boots the layer the mirror publishes and not the branch under test, and makes a layer that has never been published fail instead of pass. The comments and the documentation here named the old check and described the old behaviour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11. Follows Keel-Linux/.github#12, which renames the reusable
job
build-and-boottoboot-published-layerand makes a layer that has neverbeen published fail the job instead of passing it.
Comments and documentation only: nothing about this repository's behaviour
changes here. The rename takes effect the moment that pull request merges,
because this caller uses
@main.Branch protection on this repository's default branch requires the old check
name and must be changed to the new one when that merges. GitHub fails
closed, so the cost of forgetting is a locked repository and not an
unguarded one: a required context that is never reported leaves every pull
request blocked, waiting for a status that will never arrive. Measured on
keel-mariadb on 2026-09-28, two pull requests under the same rule with every
reported check green: number 16, reporting
appliance / build-and-boot, wasclean; number 17, reportingappliance / boot-published-layerand identicalotherwise, was
blocked. Renaming the rule is a maintainer step and is listedin the body of Keel-Linux/.github#12 with the other repositories in the same
position.