Repository navigation
Record the real cause of the layer that will not boot - #6
Merged
Merged
Conversation
The gate's failure was attributed here to bt-layer adding LAYER_CHILD_OVERLAYS to a child build and not stripping the finished layer. Pull request 1 found the narrower cause: the overlay's conffile met a dpkg prompt with stdin closed, root.patched failed, and fab therefore never reached the step that removes the build overlays. bt-layer then packed and published the tree anyway, which is what remains open in buildtasks issue 6. The recipe is fixed; the layer on the mirror is not, because it has not been rebuilt, so appliance / build-and-boot stays advisory until it is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
COVERAGE.mdandtests/README.mdattributed the boot test's failure tobt-layeraddingLAYER_CHILD_OVERLAYSto a child build and not stripping thefinished layer. #1 found the narrower cause: the overlay's conffile met a dpkg
prompt with stdin closed,
root.patchedfailed, and fab therefore never reachedthe step that removes the build overlays.
bt-layerthen packed and publishedthe tree anyway, which is what remains open in buildtasks#6.
The recipe is fixed; the layer on the mirror is not, because it has not been
rebuilt (
nodebb.manifeststill records sha25640e3f4da). Soappliance / build-and-bootstays advisory here until the layer is rebuilt andrepublished.
This pull request is also the first real CI run of the rewritten
test-appliance.ymlin this repository, so the expected outcome is: the probeanswers 200, the published parent matches
nodejs-nginx, the three layers pulland verify, the chain assembles, the container boots and gets an address, and
the job then fails on the first boot timeout. That is the gate reporting the
layer defect.
Test plan:
tests / coveragegreen.appliance / build-and-bootfails at the first boot wait, on the layer,not on the test.