Repository navigation
The appliance gate is green: record it, and what each of the four defects was - #10
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
appliance / build-and-bootpassed onmain, run 36290439227, against thechain published this morning:
COVERAGE.mdandtests/README.mdstill described the check as failing onthe build time wrappers, which has not been true since the layer was rebuilt.
They now record the green run with its measurements (assemble 33 s, address
after 5 s, first boot 50 s) and the order the four defects came in, each
hidden by the one before it:
systemctlandservicewrappers, which stopped the firstboot at
10regen-sshkeys(pull request 1, then the layer was rebuilt);redis-server.servicefailedwith
status=226/NAMESPACE(pull request 8);ssl_ciphers 'ZZ_SSL_CIPHERS'left unsubstituted, which stopped nginx(buildtasks
layer_needs_ssl_ciphers, then the layer was rebuilt again);/dev/tty1nobody reads, which blocked./nodebb setupinn_tty_writeforever (pull request 9).Documentation only; no shipped file changes, so no changelog entry.
Test plan:
tests/coverage.shunchanged and green