Repository navigation
feat: Core carries the service VIP overlay - #30
Merged
Merged
Conversation
added 2 commits
October 7, 2026 23:25
Handbook decision 0049 gives every replicated pair a VIP (databases, Keel Web pairs with file replication, WordPress later), so the overlay ships in Core like the wireguard and etcd overlays (0029). keel-core depends on keel-overlay-vip (>= 0.1.1, the first that ships its units off, Keel-Linux/common#44) and on keel (>= 0.20.0, the first that knows appliance.vip), and the manifest names vip disabled in every mode: keel enables it only on a node whose spec declares appliance.vip (0041). keel-core 0.1.3; the appliance changelog is 19.0-9, the build of the release of 2026-10-07. tests/package.bats: the dependencies and the vip entry of the manifest.
…ian does not read it as an NMU
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decision 0049 gives every replicated pair a VIP, so the overlay ships in Core like wireguard and etcd (0029).
keel-coredepends onkeel-overlay-vip (>= 0.1.1)(the first that ships its units off, fix: keel-overlay-vip ships every unit off on the first installation common#44) andkeel (>= 0.20.0)(the first that knowsappliance.vip).vip: {simple: disabled, cloud_simple: disabled, cloud_advanced: disabled}; keel enables it only for a spec that declaresappliance.vip(0041).tests/package.bats: dependency line and the vip entry (19 tests pass locally).Depends on common#44 being merged and keel-overlay-vip 0.1.1 published before the image build.