Repository navigation
fix: show a generated password once, and record the updates answer - #33
Merged
Merged
Conversation
added 2 commits
October 2, 2026 03:48
The screen that shows a generated password says it is not shown again, and the question after it showed it again (the maintainer's screenshots 002 and 003); the question no longer does. 95secupdates leaves its answer, skip or force, in /var/lib/inithooks/sec-updates, the one trace of it, which keel inspect reads: it said force after Skip (screenshot 034). First tests for 95secupdates, tests/test-secupdates.bats.
master took 2.3.6+keel15 (the Keel Linux names); this branch's entry becomes 2.3.6+keel16 above it.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the maintainer's screenshots of the Core image (2026-10-02). inithooks 2.3.6+keel16 (master took keel15; master is merged in).
forceafter Skip.95secupdatesnow writesskiporforceto/var/lib/inithooks/sec-updates, for both a preseeded and an interactive answer. keel 0.15.1 (fix: inspect, confirm and monit on a Keel Core (keel#60, keel#61) keel#64) reads that file. If the file cannot be written, the hook logs it and the boot continues. The hook now takesINITHOOKS_DEFAULT,SEC_UPDATES_RECORDandSEC_UPDATES_LOGfrom the environment, for its first tests.Tests written first:
dialog_wrapper.pystays at 98 percent (the same lines are missed). New tests check that the password appears on one screen only.tests/test-secupdates.batscovers 49 of 50 lines of95secupdates. The shell total is 99.58, against a threshold of 98.Real test: an LXC container from the step 7b Core image, with this package installed before the first boot. Generate showed the password once; the question did not show it. Choosing Skip left
skipin/var/lib/inithooks/sec-updates, and keel inspect reportedskip. The container was destroyed afterwards.