Repository navigation
0014: the two identity files, and what an appliance says about backup - #6
marcos-mendez wants to merge 2 commits into
Conversation
…ackup Issue Keel-Linux/tracker#6 asked for the login of an appliance to stop announcing another distribution, and named two questions that had to be answered before the text could be written: whether /etc/turnkey_version keeps its name now that the distribution has another one, and what an appliance says about backup now that TKLBAM is deferred by decision 0002. The answers, with the evidence behind each: the TurnKey file is an interface we honour, in its name and in its format, because five things on a running appliance parse it and every one of those parsers is prefix sensitive, and keel inspect drops the appliance identity outright for a string that begins with anything else. Keel writes /etc/keel_version beside it and that is what an operator is shown. On backup the appliance says one true line and advertises nothing: not configured, no service yet, confconsole when there is one. No URL, because the documentation page it would point at answers 404 today. The note records a defect the question uncovered: keel-core's changelog was renamed to keel-core-19.0 on 2026-09-27, and fab derives /etc/turnkey_version from that name, so the next core layer would have written a string none of its readers accepts.
|
Reviewed together with Keel-Linux/keel-core#9, Keel-Linux/common#5 and #4. Checked the factual claims rather than taking them, because this note is what the next person will reason from:
One observation rather than a finding: the reasoning in section 1 puts Keel-specific behaviour in ApproveClean above LOW. The claims that would be expensive to be wrong about are each checkable and each checked out. |
…ge lives common#5 now writes both identity files from mk/turnkey-desktop.mk too, the second copy of the same step, so the note says so. Review asked for the rule behind putting the identity files in common and the login in the product. Proposed: the compatibility surface goes in common, the operator facing surface in the product, which is what keeps common offerable upstream (0008).
Issue Keel-Linux/tracker#6 asked for an appliance to stop announcing
itself as TurnKey at login, and said the two hard parts belong in a
decision note rather than in a commit message. This is that note. It
covers those two questions and nothing else.
Does
/etc/turnkey_versionkeep its name? Yes, and its format too.It is a published interface, not branding: measured on a live appliance
on 2026-09-28, five things parse it (
turnkey-version, thesysversionlibrary,
keel.inspect.app, three inithooks files, and a tklbam hook),and every one of those parsers is prefix sensitive.
keel inspectreports the appliance as missing for a string that does not begin
turnkey-. Keel writes/etc/keel_versionbeside it, the same fourfields with its own prefix, and everything an operator is shown reads
that one and falls back to the other.
The question uncovered a live defect. keel-core's changelog was renamed
to
keel-core-19.0on 2026-09-27 and fab derives/etc/turnkey_versionfrom the changelog's package name, so the next core layer would have
written
keel-core-19.0-trixie-amd64into a file none of those readersaccepts. The published layer predates the rename, so nothing shipped is
affected. Keel-Linux/common#5 normalises the prefix so the rule is
enforced rather than hoped for.
What does the appliance say about backup? One line: not configured,
no backup service yet, confconsole when there is one. No instruction to
run
tklbam-init, because that links the machine to another project'sHub, and no URL, because the documentation page it would point at
answers 404 today.
Implemented in Keel-Linux/common#5 and Keel-Linux/keel-core#9. Neither
this nor those should be merged before the maintainer has ruled on the
note: the status line says proposed.