Repository navigation
fix: the first boot role screen skips keel inspect without a database server - #20
Merged
Merged
Conversation
added 2 commits
October 2, 2026 13:49
… server keel inspect reads the whole machine to find the engine, 2 s on a Web container and 8 s with a quarter of a CPU, while the password screen stayed up with nothing new on it (the maintainer's Proxmox console after <Saved>). With no server binary of keel's own table (keel.inspect.dbengines.ENGINES) there is nothing to find, so the role stays standalone at once; when the table cannot be read, keel is asked.
The role screen change moves to keel13: master's keel12 is the Instance menu from the appliance manifest (#19).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion of Keel-Linux/inithooks (keel17): part of the silent gap the maintainer saw on his Proxmox console after on "Did you save the password?".
On the Web image, 75keel-role runs
keelfirstboot.py role, which rankeel inspectto find a database engine the image does not have: 2 s on an LXC container, 7.7 s with a quarter of a CPU, while the password screen stayed up.find_engine()now checks first whether any server binary of keel's own table (keel.inspect.dbengines.ENGINES, the patterns keel inspect itself globs) exists. If none does, the role stays standalone at once and the journal says why, as before. If the table cannot be imported, keel is asked as before. A declared engine is still used as it is.Measured on the test VM with the inithooks PR, 0.25 CPU: to Keel Cloud went from 15 s to 7.7 s, with "Configuring keel-role... please wait" on the screen.
Tests (written first)
tests/test_first_boot.py: no server binary means no role and no keel inspect; a binary present, no binary, no table, and a table of another shape. keelfirstboot.py stays at 100 percent.Test plan