Repository navigation
fix: Database mode and network confirm screens say only what is true - #18
Merged
Merged
Conversation
added 2 commits
October 2, 2026 03:48
Database mode on a machine with no database server no longer appends keel inspect's stderr, which is about other fields (a missing fqdn in the maintainer's screenshot 045). The verdict of a refused keel network confirm (exit 21) no longer claims the change reverts when its window ends: keel refuses for several reasons, nothing waiting among them, as when another session confirmed it already (screenshot 040); it now points at keel's own line.
master took 2.2.3+keel10 (the Keel Linux names) after keel9 (the console art); this branch's entry becomes 2.2.3+keel11 above them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two confconsole screens from the maintainer's screenshots of the Core image (2026-10-02). confconsole 2.2.3+keel11 (master took keel9 and keel10; master is merged in).
dbscreen.engine_ofappended everythingkeel inspectprinted on stderr to the no-server text. inspect had written its spec, so that stderr was about other fields: here "required fields not inferred: instance.fqdn". The screen now shows only the no-server text. (keel 0.15.1, fix: inspect, confirm and monit on a Keel Core (keel#60, keel#61) keel#64, also stops requiring the fqdn.)Tests written first: 643 pass, 5 skip; the measured modules stay at 100 percent lines and branches.
Real test: LXC container from the step 7b Core image with this package, keel 0.15.1, inithooks keel15 and keel-core 0.1.1; Primary showed only the no-server text, and the console confirm after an
lxc-attachconfirm showed "already confirmed ... it stays", exit 0. Container destroyed.