Repository navigation
fix: keel-overlay-etcd depends on etcd-client (keel#83) - #48
Merged
Merged
Conversation
…m as etcd-server keel asks etcd with etcdctl over gRPC, the only way etcd 3.5 takes a client certificate's CN as its user (its JSON gateway calls etcd with the member's own certificate, and refuses a client certificate with a CN once auth is on). Keel-Linux/keel#83 makes the CN the user, so the etcd overlay brings etcdctl, and depends on the keel that asks with it (0.22.0). etcd-client and etcd-server come from Debian's etcd source, not this package's, so their binary versions cannot be tied with ${source:Version} here; both are bounded to the upstream release keel is tested against, 3.5.16, and a new upstream is a deliberate update of this package. overlay-install.bats checks that the two installed packages come from the same source version.
marcos-mendez
force-pushed
the
feat/etcd-client-for-keel
branch
from
October 8, 2026 08:11
e2f8097 to
88f5b29
Compare
The install test builds keel from its pinned commit, 0.21.0, and a dependency on a keel not yet on main cannot be met there. The direction is keel's: 0.22.0 Breaks the overlays before 0.4.0, which lack etcdctl; an older keel beside etcdctl merely leaves it unused.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The packaging half of Keel-Linux/keel#83: keel asks etcd with
etcdctlover gRPC, since etcd 3.5 maps a client certificate's CN to a user over gRPC only (its JSON gateway calls etcd with the member's own certificate and refuses CN-bearing client certificates once auth is on).etcd-client.${source:Version}equality is not possible here: etcd-client and etcd-server come from Debian'setcdsource, not this package's. So both are bounded to the same upstream release,(>= 3.5.16), (<< 3.5.17~). A new etcd upstream becomes a deliberate update of this package. This adds the upper bound to etcd-server as well.${source:Version}.keel#90 declares
Breaks: keel-overlay-etcd (<< 0.4.0~), and this package depends on keel (>= 0.22.0), the keel that asks etcd with etcdctl.