Repository navigation
ci: security scanning, with the findings read and justified - #17
Merged
Merged
Conversation
Calls security-scan.yml of keel-linux/.github (gitleaks, bandit, semgrep, shellcheck on hosted runners, no secrets) on pull requests, pushes to 19.x and by hand. Not a required check. Baseline from a scan of 19.x, none a risk. bandit B103 and semgrep's insecure-file-permissions: 0o750 on the root-owned EC2 user-data script, 0o700 on ~/.ssh. Plus 205 shellcheck warnings of existing scripts (arrays in log messages, word splitting of build paths, unused config variables), each justified in .github/security-baseline. Eight Python 2 scripts under bin/ec2_legacy and contrib cannot be parsed by bandit and are reported as warnings. gitleaks: tests/layer writes truncated fake key headers on purpose and tests/ec2-v19 named public key fingerprints, allowlisted by path in .github/gitleaks.toml; BT_GPGKEY and GPGKEY are fingerprints of the public TurnKey signing keys, ignored by fingerprint in .github/.gitleaksignore.
marcos-mendez
force-pushed
the
ci/security-scan
branch
from
October 7, 2026 18:18
74ac913 to
273e1a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calls security-scan.yml of keel-linux/.github (gitleaks, bandit,
semgrep, shellcheck on hosted runners, no secrets) on pull requests,
pushes to 19.x and by hand. Not a required check.
Baseline from a scan of 19.x, none a risk. bandit B103 and semgrep's
insecure-file-permissions: 0o750 on the root-owned EC2 user-data
script, 0o700 on ~/.ssh. Plus 205 shellcheck warnings of existing
scripts (arrays in log messages, word splitting of build paths, unused
config variables), each justified in .github/security-baseline.
Eight Python 2 scripts under bin/ec2_legacy and contrib cannot be
parsed by bandit and are reported as warnings.
gitleaks: tests/layer writes truncated fake key headers on purpose and
tests/ec2-v19 named public key fingerprints, allowlisted by path in
.github/gitleaks.toml; BT_GPGKEY and GPGKEY are fingerprints of the
public TurnKey signing keys, ignored by fingerprint in
.github/.gitleaksignore.