ci(deploy-test): bake min_clients into the test kits (default 2) - #580
Merged
Merged
Conversation
The workflow built the productive jobs with min_clients = 5 and then ran them with two test clients, which aborts in 30 s with 'min_clients (5) exceeds the number of participating clients (2)'. buildDockerImageAndStartupKits.sh already has --min-clients for exactly this; pass it, with a dispatch input defaulting to the two-client conf. Found by the v1.8.0 release-triggered run (34778471496), which first failed on the runner conf still naming the test sites RUMC_1/MHA_1 after #573; the runner-local confs on dl0 and dl2 are corrected alongside (TEST_A_1/TEST_B_1, institutions, real data paths, 2-site project). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release-triggered deploy test (34778471496, v1.8.0) failed at kit deployment because the runner-local conf still named the test sites
RUMC_1/MHA_1after #573 renamed them, and pointed at empty data directories. Those confs on dl0 and dl2 are corrected (TEST_A_1/TEST_B_1, institutions, real data paths, the 2-site project).Had it got past that, it would have aborted 30 s into the run: the workflow builds the productive jobs with
min_clients = 5and runs them with two clients.buildDockerImageAndStartupKits.shalready has--min-clientsfor exactly this case; the workflow now passes it, with a dispatch input defaulting to 2.Workflow-only change; the deploy test itself is dispatched after merge as the post-release check on the runners.
🤖 Generated with Claude Code