Skip to content

fixed output of runIntegrationTests.sh - #572

Merged
oleschwen merged 1 commit into
mainfrom
fix/integration-test-output-all-model-preflight-check
Sep 11, 2026
Merged

oleschwen merged 1 commit into
mainfrom
fix/integration-test-output-all-model-preflight-check

Conversation

@oleschwen

Copy link
Copy Markdown
Collaborator

This PR fixes confusing output from the data access preflight checks for all models

@Ultimate-Storm Ultimate-Storm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

run_all_models_preflight_check() was announcing [Run] 3DCNN local training... — a copy-paste label from the neighbouring function. One line, no functional change.

Worth more than it looks. A log line that names the wrong operation is how a green check gets misread, and that has cost real time on this repo lately: cancelled rendering identically to failure in gh pr checks led me to record #550 as "failed 4×" when it was two cancellations and two genuine failures from a stale branch. Anything that makes CI output say what it actually did is worth taking.

CI verified by conclusion rather than by the rendered status: 6/6 SUCCESS, with validate-swarm genuinely running for 18m59s rather than being evicted.

@oleschwen
oleschwen merged commit a51738c into main Sep 11, 2026
6 checks passed
@oleschwen
oleschwen deleted the fix/integration-test-output-all-model-preflight-check branch September 11, 2026 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants