539 run preflight check for all odelia models - #559
Merged
Ultimate-Storm merged 4 commits intoSep 10, 2026
Merged
Conversation
The weekly schedule does fire — run 34012983100, Sunday 2026-09-06 05:02
UTC on main — and it fails at step 23, "Run preflight check for all
productive models", after about two seconds.
Two seconds is not six models failing. The dispatcher case for
run_all_models_preflight_check calls create_synthetic_data but not
create_startup_kits_and_check_contained_files, unlike every other preflight
case. Each workflow step is a separate invocation of this script and the
EXIT trap runs cleanup_temporary_data, which removes PROJECT_DIR -- so the
kits built by the earlier create_startup_kits step no longer exist, and
run_all_models_preflight_check starts with
cd "$PROJECT_DIR"/prod_00
against a directory that is not there.
Added the missing call. The failure was in the harness, so this says
nothing yet about whether the six models actually pass; that is what the
next weekly run, or a manual workflow_dispatch, will show.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
… that preflight check has actually succeeded
oleschwen
marked this pull request as ready for review
September 9, 2026 13:19
Ultimate-Storm
approved these changes
Sep 10, 2026
Ultimate-Storm
left a comment
Contributor
There was a problem hiding this comment.
Verified rather than taken on trust:
- Your green run 34349142014 confirms
step 23: Run preflight check for all productive models -> successon aworkflow_dispatch. Agreed that PR CI alone could not have shown this. - The substantive improvement is checking
Epoch 0: 100%, not just that the right model name appeared. The previous version would have passed on a model that loaded and then died. - Splitting
_verify_ODELIA_ternary_preflight_checkout is right — that job needs--model_namewhere the challenge jobs derive it.
Flagging Swin3D with a visible ❗ instead of quietly omitting it is the right call, and it is a real finding: 12 of 13 models pass, Swin3D does not. That interacts with #541 — Swin3D is reachable through MODEL_NAME for a swarm run, so a site could select a model that cannot train. I'll open an issue for it referencing your line.
Merging.
Ultimate-Storm
deleted the
539-run-preflight-check-for-all-odelia-models
branch
September 10, 2026 08:34
This was referenced Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
Notes