Skip to content

539 run preflight check for all odelia models - #559

Merged
Ultimate-Storm merged 4 commits into
mainfrom
539-run-preflight-check-for-all-odelia-models
Sep 10, 2026
Merged

Ultimate-Storm merged 4 commits into
mainfrom
539-run-preflight-check-for-all-odelia-models

Conversation

@oleschwen

@oleschwen oleschwen commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

This PR

  • extends the weekly/manually triggered run_all_models_preflight_check test by also including ResNet variants
  • also verifies that the preflight checks have succeeded (and not just started with the correct model)

Notes

gfidlab-ci-user and others added 4 commits September 9, 2026 13:22
The weekly schedule does fire — run 34012983100, Sunday 2026-09-06 05:02
UTC on main — and it fails at step 23, "Run preflight check for all
productive models", after about two seconds.

Two seconds is not six models failing. The dispatcher case for
run_all_models_preflight_check calls create_synthetic_data but not
create_startup_kits_and_check_contained_files, unlike every other preflight
case. Each workflow step is a separate invocation of this script and the
EXIT trap runs cleanup_temporary_data, which removes PROJECT_DIR -- so the
kits built by the earlier create_startup_kits step no longer exist, and
run_all_models_preflight_check starts with

    cd "$PROJECT_DIR"/prod_00

against a directory that is not there.

Added the missing call. The failure was in the harness, so this says
nothing yet about whether the six models actually pass; that is what the
next weekly run, or a manual workflow_dispatch, will show.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
… that preflight check has actually succeeded
@oleschwen oleschwen self-assigned this Sep 9, 2026
@oleschwen oleschwen changed the title WIP 539 run preflight check for all odelia models 539 run preflight check for all odelia models Sep 9, 2026
@oleschwen
oleschwen marked this pull request as ready for review September 9, 2026 13:19

@Ultimate-Storm Ultimate-Storm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified rather than taken on trust:

  • Your green run 34349142014 confirms step 23: Run preflight check for all productive models -> success on a workflow_dispatch. Agreed that PR CI alone could not have shown this.
  • The substantive improvement is checking Epoch 0: 100%, not just that the right model name appeared. The previous version would have passed on a model that loaded and then died.
  • Splitting _verify_ODELIA_ternary_preflight_check out is right — that job needs --model_name where the challenge jobs derive it.

Flagging Swin3D with a visible instead of quietly omitting it is the right call, and it is a real finding: 12 of 13 models pass, Swin3D does not. That interacts with #541 — Swin3D is reachable through MODEL_NAME for a swarm run, so a site could select a model that cannot train. I'll open an issue for it referencing your line.

Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants