[pull] master from comfyanonymous:master - #106
Open
pull[bot] wants to merge 4485 commits into
Open
Conversation
Changes: Remove sequential scan hint Prefer NVML pressure on windows Add async malloc clamp option (unused by comfy so far) Workaround AMD windows GPU virtual address space leak The largest change is the NVML pressure, which works around a cuMemGetInfo drift from actual VRAM in some circumstances.
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
This priority scheme was broken in the case where you have pin registration exhaustion while loading a VBAR that gets a big evicition. The weight would stay in the loaded set but inherit the MRU priority against other workflow models WRT pin registration which leads to async offload without pinning. Fix by universally promiting active pin registration above workflow pins without concern for the weights/weights-loaded split. This diverges from the actual budgeting where the split still makes sense.
This avoids name collision (circular imports) for external custom nodes, for which the comfy path is pushed into sys.path so Python's own logging module is shadowed otherwise. fixes: #15229
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…l Try-On API (#15249) Signed-off-by: bigcat88 <bigcat88@icloud.com>
This is performance critical for ACE step.
…ort (#15294) Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
* [Partner Nodes] feat(BFL): add Flux 3 video model Signed-off-by: Alexander Piskun <bigcat88@icloud.com> * [Partner Nodes] fix(BFL): harden keyframe value check Signed-off-by: Alexander Piskun <bigcat88@icloud.com> --------- Signed-off-by: Alexander Piskun <bigcat88@icloud.com> Co-authored-by: Jedrzej Kosinski <kosinkadink1@gmail.com>
Co-authored-by: Jedrzej Kosinski <kosinkadink1@gmail.com>
Comfy-aimdo 0.4.12 increases error logging reliablity to help root cause os errors in some of the C APIs that are causing issues for some users. The log is also unified with python logging, so non-terminal users see the logs properly. Aimdo 0.4.13 fixes a bug in async-offload + MRU primary weights allocation. #15284
AMD+windows sets an unusually low maximum GPU virtual memory quota compared to other plaforms. For reference, the hardware limits on XT9060 are 128TB. On Nvidia RTX3060 it is 1TB. On nvidia RTX5090 it is 128TB. Bump this into the same league, but keep it to a modest 4TB pending further usage case need + testing going even higher to the hardware limits.
…#16188) * [Partner Nodes] feat(OpenRouter): add MAI-Image-2.6 image node Signed-off-by: Alexander Piskun <bigcat88@icloud.com> * [Partner Nodes] fix(api-client): show provider error details Signed-off-by: Alexander Piskun <bigcat88@icloud.com> --------- Signed-off-by: Alexander Piskun <bigcat88@icloud.com> Co-authored-by: Daxiong (Lin) <contact@comfyui-wiki.com>
…text node (#16195) Signed-off-by: Alexander Piskun <bigcat88@icloud.com> Co-authored-by: Purz <97489706+purzbeats@users.noreply.github.com>
…ment node and retire the dead widgets (#16201) * [Partner Nodes] feat(Tripo): migrate all nodes to the v3 API and add the Smart Segment node Signed-off-by: bigcat88 <bigcat88@icloud.com> * [Partner Nodes] feat(Tripo): deprecate Text to Model, Image to Model and Texture model in favour of V2 nodes without the retired widgets Signed-off-by: bigcat88 <bigcat88@icloud.com> * [Partner Nodes] fix(Tripo): report the mixamo retarget limitation for rigs whose v3 task echo carries no model version Signed-off-by: bigcat88 <bigcat88@icloud.com> * [Partner Nodes] fix(Tripo): keep the Smart Segment widgets inside the source options so the frontend can build the node Signed-off-by: bigcat88 <bigcat88@icloud.com> * [Partner Nodes] fix(Tripo): correct the Retarget and Smart Segment tooltips to what Tripo accepts Signed-off-by: bigcat88 <bigcat88@icloud.com> --------- Signed-off-by: bigcat88 <bigcat88@icloud.com>
…age node (#16229) Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
…aser node (#16264) * [Partner Nodes] feat(Bria): add eight image edit nodes and the Video Eraser node Signed-off-by: Alexander Piskun <bigcat88@icloud.com> * [Partner Nodes] fix(Bria): clarify the reference images tooltip Signed-off-by: Alexander Piskun <bigcat88@icloud.com> --------- Signed-off-by: Alexander Piskun <bigcat88@icloud.com> Co-authored-by: Daxiong (Lin) <contact@comfyui-wiki.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )