Train test val split - #34
Open
ClaudiaWinklmayr wants to merge 3 commits into
Open
Conversation
jeromel05
reviewed
Mar 21, 2025
jeromel05
left a comment
jeromel05
left a comment
There was a problem hiding this comment.
Added some small suggestions for reusability and readability of the code
| @@ -0,0 +1,190 @@ | |||
| { | |||
| "cells": [ | |||
There was a problem hiding this comment.
Would be nice to have this as a python script rather than a Notebook, it would make it way easier to track changes
| import shutil | ||
| import pandas as pd | ||
|
|
||
| orig_train_path = Path("/fast/AG_Kainmueller/data/patho_foundation_model_bench_data/arctique_dataset/original_data//v1-0/train") #Path("C:/Users/cwinklm/Documents/Data/v_review_sample10/train") |
There was a problem hiding this comment.
Would be nice to have this in a run() function that is called with "if name == "main":"
Also, would be nice to use argparse to get the arguments like paths etc, this would make the script reusable if the data changes location, or if we want to adapt it to another dataset
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this PR?
added the script to create the train-test-val spilt for arctique
How did you implement your changes?
How did you test your changes?
Remaining issues