Skip to content

Disable EditorAnimatedPartsShipModified if DMagicOrbitalScience is installed #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Phantomical merged 2 commits into from
Jul 19, 2026
Merged

Disable EditorAnimatedPartsShipModified if DMagicOrbitalScience is installed #413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
105d2a3
Disable EditorAnimatedPartsShipModified if DMOS is installed
Phantomical Jul 17, 2026
383cadd
Add CHANGELOG entry
Phantomical Jul 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
##### Unreleased
**Bug Fixes**
- **EditorAnimatedPartsShipModified** : Fixed a memory leak ([issue #396](https://github.com/KSPModdingLibs/KSPCommunityFixes/issues/396)) where listeners were not properly cleaned up.
- **EditorAnimatedPartsShipModified** : This patch is now disabled if DMagic Orbital Science is installed because DMagic Orbital Science has a bug that causes a stack overflow crash if you ever call `DMSoilMoisture.OnStop`, which this patch does.

##### 1.41.1
**Bug Fixes**
Expand Down
12 changes: 12 additions & 0 deletions GameData/KSPCommunityFixes/MMPatches/ModSupport/DMagicOrbitalScience.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
// DMSoilMoisture.OnStop causes a stack overflow when called. The
// EditorAnimatedPartsShipModified patch calls OnStop on all IScalarModules on
// the ship. It ends up triggering the stack overflow which then crashes KSP.
//
// We disable the patch if DMagicOrbitalScience is installed to avoid this.
//
// See https://github.com/KSPModdingLibs/KSPCommunityFixes/issues/409

@KSP_COMMUNITY_FIXES:NEEDS[DMagicOrbitalScience]
{
@EditorAnimatedPartsShipModified = false
}