Fix various UI bugs in the RealFuelsWindow - #371
Merged
Conversation
Contributor
Author
|
Fixed a couple things pointed out by siimav. Unlocked tanks scaling up is intentional, but we do also scale empty volume now. To cover the default case, if the percentage field is 100% then we propagate that over to the Amount field (if it's not active), otherwise we propagate the Amount field to the percentage field. Locks are still a mess and I feel like it needs a rewrite to be inherent to the tank so that it's not dependent on the UI being open. I'm not currently willing to work on that. |
Contributor
|
This does not build |
siimav
requested changes
Jul 27, 2026
Contributor
Author
|
I got sidetracked for a bit, but I think I covered everything. The extra decimal point does sort of exacerbate the existing width issue for certain mixes (I stare at the Valois with its 4-resource mix) which is not ideal... |
siimav
reviewed
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd separate these but they're each like 10 lines at most