Pin pytest below 9 until pytest-pylint supports it#4
Merged
Conversation
pytest 9 removed the legacy 'path' hook parameter that pytest-pylint 0.21.0 still declares, so every run dies at plugin registration (carsongee/pytest-pylint#197); no compatible pytest-pylint release exists.
Maximilian-Nesslauer
added
the
infrastructure
averageksp
approved these changes
Jul 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Pins pytest below 9 in the
testanddevelopmentextras.Why
A fresh
pip install .[test]now resolves pytest 9.x, and pytest-pylint 0.21.0 registers a hookimpl with the legacypathparameter that pytest 9 removed, so every run dies with an INTERNALERROR at plugin registration before a single test is collected (carsongee/pytest-pylint#197). All four CI jobs fail on any cold run because of this, see #3. pytest-pylint has no compatible release (latest is from Oct 2023 and the issue is open in its master too), so the alternatives are this pin or dropping pytest-pylint, and the latter is an upstream maintenance decision.Upstream KSP-CKAN/NetKAN-Infra will hit the same failure on its next CI run (its last one predates pytest 9), so this is also a candidate for a small standalone upstream PR.
Testing
The full suite is green with pytest 8.3.5 on Python 3.12 (284 passed locally); the CI runs on this PR exercise the pin directly.