Skip to content

Add the KSA inflator to deploy.yml and bounce.yml - #45

Merged
Maximilian-Nesslauer merged 1 commit into
KSAModding:masterfrom
Maximilian-Nesslauer:ksa-inflator-deploy-bounce
Jul 4, 2026
Merged

Add the KSA inflator to deploy.yml and bounce.yml#45
Maximilian-Nesslauer merged 1 commit into
KSAModding:masterfrom
Maximilian-Nesslauer:ksa-inflator-deploy-bounce

Conversation

@Maximilian-Nesslauer

Copy link
Copy Markdown
Member

What

Adds the KSA inflator to the two workflows that enumerate the per-game inflator services, mirroring how KSP2 appears in the same places:

  • deploy.yml: InflatorKsa joins the redeploy loop in the upload-inflator job.
  • bounce.yml: Ksa joins the game matrix (the job derives the service name as Inflator${{ matrix.game }}).

Deliberately nothing else: the diff stays a pure mirror of the existing KSP2 entries.

Sequencing

Both workflows are disabled in this fork (they need upstream's DockerHub/AWS secrets), so the change is inert here; the files ship with the eventual upstream PR. The InflatorKsa ECS service itself is created from NetKAN-Infra's prod-stack.py (KSAModding/NetKAN-Infra#3) by the CKAN team's AWS deploy. Two notes to carry into the upstream PR body (#37):

  • Until that service exists, the redeploy-service --service-name InflatorKsa call fails, but the deploy step still reports green because the loop backgrounds the calls and closes with a bare wait (pre-existing pattern, unchanged here). So landing these entries before the service is provisioned does not break deploys.
  • A bounce dispatched during that window shows a failing Ksa matrix job, and with the workflow's default fail-fast the sibling Ksp/Ksp2 jobs get cancelled. Left as-is to keep the diff minimal; worth mentioning upstream so a bounce is not dispatched between the client merge and the service provisioning.

Verification

YAML parse of both files is clean, plus a semantic check that the matrix is [Ksp, Ksp2, Ksa]. No runnable surface in this fork (both workflows disabled).

Closes #36. Part of KSP-CKAN#4457.

- deploy.yml: include InflatorKsa in the upload-inflator redeploy loop
- bounce.yml: add Ksa to the matrix
@Maximilian-Nesslauer Maximilian-Nesslauer added enhancement New feature or request infrastructure Infra/workflow plumbing around the client labels Jul 4, 2026
@github-project-automation github-project-automation Bot moved this to Todo in CKAN-KSA Jul 4, 2026
@Maximilian-Nesslauer Maximilian-Nesslauer moved this from Todo to In Progress in CKAN-KSA Jul 4, 2026
@Maximilian-Nesslauer
Maximilian-Nesslauer merged commit 59807e1 into KSAModding:master Jul 4, 2026
5 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in CKAN-KSA Jul 4, 2026
@Maximilian-Nesslauer
Maximilian-Nesslauer deleted the ksa-inflator-deploy-bounce branch July 4, 2026 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request infrastructure Infra/workflow plumbing around the client

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Add the KSA inflator to deploy.yml and bounce.yml

2 participants