Skip to content

Add files via upload - #1

Open
ahmetinan79 wants to merge 1 commit into
mainfrom
ahmetinan79-patch-1
Open

Add files via upload#1
ahmetinan79 wants to merge 1 commit into
mainfrom
ahmetinan79-patch-1

Conversation

@ahmetinan79

Copy link
Copy Markdown

No description provided.

Comment thread week1_assignment.css
Comment on lines +1 to +4
div.Header1 {
height: 40px;
background:purple;
color: white;

@Fatiherik Fatiherik Oct 22, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

div.Header1 yerine Header1 yazsaniz daha iyi olur

Comment thread week1_assignment.css
Comment on lines +38 to +42

section#main {
height: 600px;
margin:auto;
}

@Fatiherik Fatiherik Oct 22, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yaptiginiz yanlis degil ama id yerine class ile ulassaniz daha guzel olabilir. (section yazmaya gerek yok)

Comment thread week1_assignment.css
Comment on lines +48 to +53

section#activities img {
float: left;
width: 75%;
height: 75%;
}

@Fatiherik Fatiherik Oct 22, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

float yerine flex ile yapmayi deneyin bir de

Comment thread week1_assignment.css
Comment on lines +113 to +116
text-align: center;
float: left;
display: flex;
flex-direction: row;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

floata gerek var mi emin degilim?

Comment thread week1_assignment.html
Comment on lines +4 to +8
<meta charset="utf-8">
<meta name="viewport" content="width=device-width initial-scale=1.0">
<link rel="stylesheet" type="text/css" href="week1_assignment.css">
<head>
<body>

@Fatiherik Fatiherik Oct 22, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style ayri css dosyasinda yazmaniz guzel aliskanlik

Comment thread week1_assignment.html
Comment on lines +56 to +57
<a class="aMeeting" href="" style="color:white; background: lawngreen; margin-left: 25px; padding:5px; border-radius: 10px;">Lees verder</a>
</p>

@Fatiherik Fatiherik Oct 22, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yanlis degil ama uzun stil kodlarini css dosyasina yazmaniz daha guzel olur

@Fatiherik

Copy link
Copy Markdown
Contributor

Temiz kod yazmissiniz, okumayi cok kolaylastirmis.
Layoutun semantigi guzel olmus, section section ayirmaniz da iyi olmus.
id ve class isimlerinin divle alakali olmasi da guzel.
Koda bazi oneriler ekledim, buralara tekrar bakabilirsiniz.
Genel olarak basarili :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants