Skip to content

chore(upstream): accept Codex 0.157.1 - #1354

Merged
Juliusolsson05 merged 5 commits into
integration/batch-2026-09-27-qfrom
chore/accept-codex-0157
Sep 27, 2026
Merged

Juliusolsson05 merged 5 commits into
integration/batch-2026-09-27-qfrom
chore/accept-codex-0157

Conversation

@Juliusolsson05

@Juliusolsson05 Juliusolsson05 commented Sep 27, 2026 •

Copy link
Copy Markdown
Owner

Fixes #234 (accepting 0.157.1 with its known gaps filed; see below). Package side: Juliusolsson05/codex-headless#58 (its own accepted version was 0.149.1).

Plan and evidence: docs/plans/2026-09-26-accept-codex-0157.md (first commit).

Change

support/upstream-versions.json: Codex accepted goes from 0.130.0 to 0.157.1 (checkedAt 2026-09-26). That is the only change; no code changes. The package pointer is not moved here.

Review evidence (details in the plan)

  • Release notes, 0.149.1 → 0.157.1: nothing that breaks what Agent Code reads. The composer hint row is unchanged in the 0.157.1 recording, and none of the 1,850 local rollout files is compressed.
  • Rollout corpus, counted (a 2026-09-26 snapshot; the corpus grows while agents run):
    • The only new top-level type is token_usage_record (agent-transcript-parser#38).
    • 0.157 records the prompt as a role-user response_item plus item_completed instead of event_msg:user_message. Ownership and the session list read the former.
  • Screen: raw 0.157.0 and 0.157.1 recordings pin the composer classifier (codex-headless#54, fix(dispatch): bulk attach and mode-aware reader focus #57).
  • Runtime: daily 0.157.1 use in Agent Code since 2026-09-25.
  • The 0.130.0 → 0.149 step was already accepted by codex-headless on 2026-08-24; the app entry had not followed it.

Known gaps found in review

Each is filed. All but #1289 are confirmed inherited from the already-accepted 0.149.1, so accepting 0.157.1 does not make them worse:

Update 2026-09-27: #1362, #1363 and #1289 are now CLOSED (#1363 by #1407). Round-2 review b's two surviving prompt-extraction mutations are both killed on origin/main, so no new issue is needed. The plan's wrong fixture parenthetical (round-2 a/b) is corrected in 581d83cc: the pinned d42cc1da already contains tall-draft-ctrlc.json.

  • codex-headless#59: listCodexSessions summaries show the injected AGENTS/environment block. Agent Code's picker reads Codex's own index and is unaffected.
  • codex-headless#62: the semantic tool lifecycle ignores item_completed (CommandExecution/McpToolCall), the only tool form since 0.149.
  • agent-code#1362: read_agent_transcript drops custom_tool_call exec commands.
  • agent-code#1363: the no-index conversation fallback reads only event_msg:user_message.
  • agent-code#1289 (existing): 0.157 compacted payloads have no type, so no compaction boundary renders.
  • codex-headless#60: the recorded rollout-ownership tests run past 5 s under load.
  • agent-transcript-parser#38: token_usage_record is uncatalogued.

Unverified, stated as residual

0.157.0 #47178 made the fullscreen transcript the default. The composer classifier is pinned in that mode: the 0.157.1 recording uses the alternate screen. Trust and approval overlays have no 0.157 recording.

Known caveat (B6 decision: merge without waiting)

Two 0.157.1 breaks found by the acceptance review are still present at the app's pinned codex-headless until the pointer moves:

  • the trust dialog (codex-headless#65, fixed by codex-headless#67);
  • the prompt-input profile (codex-headless#63, fixed by codex-headless#69).

accepted feeds only the upstream-watch workflow, and this PR changes no runtime behaviour. Follow-up: bump the codex-headless pointer, and resync the lockfile, once #67 and #69 merge.

🤖 Generated with Claude Code

Juliusolsson05 and others added 2 commits September 26, 2026 20:36
Refs #234

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Compatibility review in docs/plans/2026-09-26-accept-codex-0157.md: release
notes, a rollout-corpus survey by version, the 0.157 PTY recordings, and
daily production use. The one parser-side gap (token_usage_record) is
agent-transcript-parser#38.

Fixes #234

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Juliusolsson05
Juliusolsson05 marked this pull request as draft September 27, 2026 05:51
@Juliusolsson05

Copy link
Copy Markdown
Owner Author

Blocked — do not merge. The acceptance review did its job: it found three real 0.157.x breaks, all binary-verified and none inherited from 0.149.1:

  • codex-headless#63: the prompt-input profile refuses every Codex after 0.149.1 (unsupported-cli at 0.157.1), so fresh-rollout ownership through prompt evidence is dead;
  • codex-headless#64: the write-stdin approval overlay (0.151+) is never detected, so approval automation hangs;
  • codex-headless#65: 0.156 reworded the trust dialog to "Trust this folder?", so every trust detector misses it on the fallback path.

The accepted version stays at 0.149.1 until those land. This PR is converted to draft and will be rebased onto the fixes. The earlier known-gaps list still stands.

@Juliusolsson05

Copy link
Copy Markdown
Owner Author

Parked (W1, 2026-09-27), not abandoned. This bump waits on the two 0.157.1 blockers the review found:

  • codex-headless#65, trust dialog: fixed in codex-headless#67. All three verifications are in, and one reviewer re-verification is running.
  • codex-headless#63, prompt-input profile: fixed in codex-headless#69, awaiting its three reviews.

codex-headless#64 (write-stdin approval) is no longer a blocker: the overlay is behind the off-by-default write_stdin_approval flag in 0.157.1 (evidence on #64).

Once #67 and #69 merge, this PR takes their pointers, re-runs the acceptance gate and leaves draft. New 0.157 findings from that work are tracked separately: #66 (background server) and #68 (a ? dropped from single-line prompts).

…s are closed and the prompt mutations are killed on main (#1354 round 2)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Juliusolsson05
Juliusolsson05 marked this pull request as ready for review September 27, 2026 20:25
@Juliusolsson05
Juliusolsson05 marked this pull request as draft September 27, 2026 20:26
@Juliusolsson05
Juliusolsson05 changed the base branch from main to integration/batch-2026-09-27-p September 27, 2026 20:35
@Juliusolsson05
Juliusolsson05 changed the base branch from integration/batch-2026-09-27-p to main September 27, 2026 20:35
@Juliusolsson05

Copy link
Copy Markdown
Owner Author

Disposition (W1, final): supersedes the "Blocked" and "Parked" comments above

@Juliusolsson05
Juliusolsson05 marked this pull request as ready for review September 27, 2026 20:37
@Juliusolsson05
Juliusolsson05 changed the base branch from main to integration/batch-2026-09-27-q September 27, 2026 21:03
@Juliusolsson05
Juliusolsson05 merged commit d361428 into integration/batch-2026-09-27-q Sep 27, 2026
2 checks passed
@Juliusolsson05
Juliusolsson05 deleted the chore/accept-codex-0157 branch September 27, 2026 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

provider:codex Affects Codex integration sev:P3 Minor type:chore Maintenance, deps, tests, docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(upstream): Codex 0.157.1 is newer than accepted 0.130.0

1 participant