Skip to content

recordings: capture session:transport-gap so a replay shows the gap row (#1381 follow-up) #1444

Description

@Juliusolsson05

Follow-up of #1381 / PR #1442.

Session recordings (SessionRecorderManager's channel list, recordedSession, reconstructSlices) do not capture session:transport-gap, nor the transportGaps field of the initial history chunk. A recording of a session that lost a proxy span therefore replays without the durable "not captured" row the user saw.

Fix shape:

  • add the channel to the recorded set;
  • fold it into the reconstructed runtime's transportGaps;
  • pin it with a replay test.

🤖 Generated with Claude Code

No activity

Activity on this issue will appear here.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions